Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2399, fix #2752 #2755

Merged
merged 13 commits into from
May 2, 2023
Merged

fix #2399, fix #2752 #2755

merged 13 commits into from
May 2, 2023

Conversation

sramazzina
Copy link
Contributor

@sramazzina sramazzina commented Mar 21, 2023

fix #2752 ComboVar component not correctly disposed
fix #2399 I would like to have the JDBC Meta plugin

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@sramazzina sramazzina marked this pull request as draft March 21, 2023 12:30
@sramazzina sramazzina marked this pull request as ready for review March 23, 2023 15:19
@sramazzina sramazzina added this to the 2.5 milestone Mar 23, 2023
@hansva
Copy link
Contributor

hansva commented Mar 31, 2023

We should make this transform work without having to feed it the 1 dummy line.
I first thought it wasn't working... When you select something like "schema" or "catalog" it does not return any lines and those do not need input fields.

@sramazzina
Copy link
Contributor Author

Good catch! You are totally right and I agree with you. The code was ported as it was so I'll work on this.

@sramazzina sramazzina marked this pull request as draft April 4, 2023 20:55
… wherever needed.

[ITA-TRANS] Fixed a minor typo in Italian translation
# Conflicts:
#	assemblies/plugins/transforms/jdbc-metadata/pom.xml
#	plugins/transforms/jdbc-metadata/pom.xml
#	plugins/transforms/jdbc-metadata/src/main/java/org/apache/pipeline/transform/jdbcmetadata/JdbcMetadata.java
#	plugins/transforms/jdbc-metadata/src/main/java/org/apache/pipeline/transform/jdbcmetadata/JdbcMetadataData.java
#	plugins/transforms/jdbc-metadata/src/main/java/org/apache/pipeline/transform/jdbcmetadata/JdbcMetadataDialog.java
@sramazzina sramazzina marked this pull request as ready for review April 17, 2023 13:24
@hansva hansva merged commit 7b9ed26 into apache:master May 2, 2023
@sramazzina sramazzina deleted the 2399 branch May 3, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants