Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2021 Dimension lookup transform #2032

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Conversation

nadment
Copy link
Contributor

@nadment nadment commented Dec 9, 2022

  • Fix lost TK field
  • Fix folder tab Versioning layout
  • Propose the table fields names in key fields column
  • Resolve schema and table name when getting a lookup field
  • Sort table fields on name
  • Replace FocusListener and ModifyListener
  • Store DimensionUpdateType has code
  • Fix error with DATE_INSERTED, DATE_UPDATED and DATE_INSERTED_UPDATED
  • Sequence name can be changed without sequence mode selected

@nadment nadment changed the title Fix #2021 Fix #2021 Dimension lookup transform Dec 9, 2022
@hansva hansva self-requested a review December 15, 2022 09:07
@hansva hansva self-assigned this Dec 15, 2022
@hansva
Copy link
Contributor

hansva commented Dec 15, 2022

Value fields are not inserted correctly, Trying to figure out what is going wrong.

@hansva hansva marked this pull request as draft December 15, 2022 13:21
@nadment nadment marked this pull request as ready for review December 27, 2022 20:44
@nadment nadment marked this pull request as draft December 28, 2022 15:22
@nadment
Copy link
Contributor Author

nadment commented Dec 28, 2022

Wait found a another bug but can change this PR to draft.

- Fix lost TK field
- Fix folder tab Versioning layout
- Propose the table fields names in key fields column
- Resolve schema and table name when getting a lookup field
- Sort table fields on name
- Replace FocusListener and ModifyListener
- Store DimensionUpdateType has code
- Fix error with DATE_ISNSERTED, DATE_UPDATED and DATE_INSERTED_UPDATED
- Sequence name can be changed without sequence mode selected
@nadment nadment marked this pull request as ready for review December 28, 2022 17:27
@hansva
Copy link
Contributor

hansva commented Jan 2, 2023

Seems to be working again! Thanks @nadment !

@hansva hansva merged commit 779cbd7 into apache:master Jan 2, 2023
@nadment nadment deleted the HOP-2021 branch May 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants