Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Hop is shipped with jdbc driver of mssqlnative. Should it? #2445

Closed
gijoe88 opened this issue Feb 20, 2023 · 1 comment
Closed

[Bug]: Hop is shipped with jdbc driver of mssqlnative. Should it? #2445

gijoe88 opened this issue Feb 20, 2023 · 1 comment
Milestone

Comments

@gijoe88
Copy link
Contributor

gijoe88 commented Feb 20, 2023

Apache Hop version?

2.3.0 and Development

Java version?

11.0.18

Operating system

Windows

What happened?

In the zip downloaded
image

In the docker for hop-web

docker run --rm --name hop-mssql apache/hop-web:Development ls -al --color /usr/local/tomcat/plugins/databases/mssqlnative/lib
# total 1192
# drwxr-xr-x 2 root root    4096 Feb 17 09:02 .
# drwxr-xr-x 3 root root    4096 Feb 17 09:02 ..
# -rw-r--r-- 1 root root 1209660 Nov 14  2019 mssql-jdbc-7.4.1.jre8.jar

In the docker for hop-server

docker run -d --rm --name hop-mssql apache/hop:Development
docker exec -it hop-mssql ls -al --color /opt/hop/hop/plugins/databases/mssqlnative/lib
# total 1192
# drwxr-xr-x    2 hop      hop           4096 Feb 17 09:02 .
# drwxr-xr-x    3 hop      hop           4096 Feb 17 09:02 ..
# -rw-r--r--    1 hop      hop        1209660 Nov 14  2019 mssql-jdbc-7.4.1.jre8.jar

The packages all come with a JDBC driver for mssqlnative shipped inside. According to the help page, this should not be the case, and a download link is provided.

Issue Priority

Priority: 3

Issue Component

Component: Other

@bamaer
Copy link
Contributor

bamaer commented Feb 20, 2023

shipping with the MS SQL native JDBC driver is not a problem, as this driver is distributed with the MIT license.
we could definitely upgrade to a newer driver version.

gijoe88 added a commit to gijoe88/hop that referenced this issue Feb 21, 2023
gijoe88 added a commit to gijoe88/hop that referenced this issue Feb 21, 2023
gijoe88 added a commit to gijoe88/hop that referenced this issue Feb 21, 2023
hansva added a commit that referenced this issue Feb 21, 2023
#2445: Upgrading mssqlnative jdbc driver to 11.2.3 and updating the docs
@hansva hansva added this to the 2.4 milestone Feb 21, 2023
@hansva hansva closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants