HIVE-28601: Leverage configurable getPartitions API in HMS to decrease memory footprint in HS2 #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armitage420
force-pushed
the
HIVE-28601
branch
from
0f06bdf to
9863caf
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
armitage420
force-pushed
the
HIVE-28601
branch
from
9863caf to
b87ca71
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
armitage420
force-pushed
the
HIVE-28601
branch
from
b87ca71 to
f5cd0c7
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
armitage420
force-pushed
the
HIVE-28601
branch
from
f5cd0c7 to
9395708
Compare
armitage420
changed the title
armitage420
changed the title
armitage420
force-pushed
the
HIVE-28601
branch
from
9395708 to
2c0d8c5
Compare
armitage420
force-pushed
the
HIVE-28601
branch
from
c2b7308 to
0b39d27
Compare
|
@deniskuzZ Thank you so much for your review again! |
asf-ci-hive
added
tests passed
tests pending
tests failed
and removed
tests pending
tests passed
labels
armitage420
force-pushed
the
HIVE-28601
branch
from
0b39d27 to
7ce59b0
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
|
The build is green! phew! :') |
…e memory footprint in HS2
armitage420
force-pushed
the
HIVE-28601
branch
from
7ce59b0 to
0a9bdfb
Compare
asf-ci-hive
added
tests pending
tests failed
tests unstable
and removed
tests passed
tests pending
tests failed
tests unstable
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Leverage configurable getPartitionsWithSpecs API in HMS to decrease memory footprint in HS2
Why are the changes needed?
The primary motivation behind these changes is to optimize the performance of certain API calls within HS2. These calls often require specific elements, such as say location, without needing the complete storage descriptor in partition object. Transmitting the full object in these cases results in unnecessary overhead and resource consumption. By leveraging the getPartitionsWithSpecs API, we can fetch only the necessary Partition's sub-objects, thereby reducing the memory footprint and hence reducing unnecessary network usage. (A document is added with the jira for more details on how the APIs work, and performance impact it can make)
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Provided tests and added JUnit test class