HIVE-27991: Utilise FanoutWriters when inserting records in an Iceberg table when the records are unsorted #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
743bb1a
to
6df0cd8
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
6df0cd8
to
bff4105
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
zhangbutao
reviewed
Jan 12, 2024
...iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/writer/HiveIcebergRecordWriter.java
Outdated
Show resolved
Hide resolved
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
bff4105
to
47cfb3b
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
47cfb3b
to
9b0a1b7
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
9b0a1b7
to
a0c21e3
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
a0c21e3
to
56e9115
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
…g table when the records are unsorted
SourabhBadhya
force-pushed
the
HIVE-27991
branch
from
56e9115
to
9037748
Compare
|
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Feb 9, 2024
…g table when the records are unsorted (apache#4988) (Sourabh Badhya reviewed by Butao Zhang)
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Mar 7, 2024
…g table when the records are unsorted (apache#4988) (Sourabh Badhya reviewed by Butao Zhang)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Utilise FanoutWriters when inserting records in an Iceberg table when the records are unsorted
Why are the changes needed?
FanoutWriter is a writer in Iceberg which can be used to write records in a table. This writer keeps all the file handles open, until the write is finished. FanoutWriters is used as the writer when the incoming records are unsorted. We can by default have some mechanism to switch to using FanoutWriters instead of ClusteredWriters when custom sort expressions are not present for the given table/query.
Similar stuff is already implemented in Spark - apache/iceberg#8621
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
QTests