Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desensitize sensitive information #2800

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

Ceilzcx
Copy link
Contributor

@Ceilzcx Ceilzcx commented Nov 2, 2024

What's changed?

#2792

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Ceilzcx Ceilzcx linked an issue Nov 2, 2024 that may be closed by this pull request
@Ceilzcx Ceilzcx requested a review from tomsun28 November 2, 2024 05:40
@Ceilzcx Ceilzcx closed this Nov 2, 2024
@Ceilzcx Ceilzcx reopened this Nov 2, 2024
yuluo-yx
yuluo-yx previously approved these changes Nov 2, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented Nov 3, 2024

Hi, if the user edits the information on the ui page, but clicks OK without making any changes, is the real data already replaced by ****?

@Ceilzcx
Copy link
Contributor Author

Ceilzcx commented Nov 5, 2024

Hi, if the user edits the information on the ui page, but clicks OK without making any changes, is the real data already replaced by ****?

desensitize should implement by the server, It's inevitable replace to ***.

@tomsun28
Copy link
Contributor

tomsun28 commented Nov 6, 2024

desensitize should implement by the server, It's inevitable replace to ***.

hi yes, we need to consider the case where the user modifies the content and the request data is *** but the data is not modified. If the database stores the ***, there will be problems.

@tomsun28
Copy link
Contributor

Discuss with @Ceilzcx, we decided to suspend this issue until a better solution.

@zqr10159 zqr10159 marked this pull request as draft November 20, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Desensitize text in the message notification
4 participants