Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]:Improve plugin #2744

Merged
merged 6 commits into from
Sep 24, 2024
Merged

[improve]:Improve plugin #2744

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60e69be
[doc] : add committer introduction doc
Yanshuming1 Jul 27, 2024
9b626b9
[doc] : add committer introduction doc
Yanshuming1 Jul 28, 2024
58196b1
Merge remote-tracking branch 'upstream/master'
Yanshuming1 Jul 29, 2024
bc3916d
Merge remote-tracking branch 'upstream/master'
Yanshuming1 Aug 4, 2024
04de64c
Merge remote-tracking branch 'upstream/master'
Yanshuming1 Sep 23, 2024
aa4c9b8
[improve]:improve plugin
Yanshuming1 Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions manager/src/main/java/org/apache/hertzbeat/manager/service/impl/PluginServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ public void deletePlugins(Set<Long> ids) {
plugin.setEnableStatus(false);
updateStatus(plugin);
}
// reload classloader
loadJarToClassLoader();
for (PluginMetadata plugin : plugins) {
try {
Expand All @@ -146,8 +147,7 @@ public void deletePlugins(Set<Long> ids) {
}
pluginParamDao.deletePluginParamsByPluginMetadataIdIn(ids);
syncPluginStatus();
// reload classloader
loadJarToClassLoader();

}

/**
Expand All @@ -167,7 +167,7 @@ public void updateStatus(PluginMetadata plugin) {
PluginMetadata metadata = pluginMetadata.get();
metadata.setEnableStatus(plugin.getEnableStatus());
metadataDao.save(metadata);
syncPluginStatus();
syncSinglePluginStatus(metadata);
} else {
throw new IllegalArgumentException("The plugin is not existed");
}
Expand Down Expand Up @@ -368,6 +368,18 @@ private void syncPluginStatus() {
ITEM_TO_PLUGINMETADATAID_MAP.putAll(itemToPluginMetadataIdMap);
}

private void syncSinglePluginStatus(PluginMetadata plugin) {
if (plugin == null || CollectionUtils.isEmpty(plugin.getItems())){
return;
}
for (PluginItem item : plugin.getItems()) {
PLUGIN_ENABLE_STATUS.put(item.getClassIdentifier(), plugin.getEnableStatus());
ITEM_TO_PLUGINMETADATAID_MAP.put(item.getClassIdentifier(), plugin.getId());
}


}

@PostConstruct
private void initParams() {
try {
Expand Down
Loading