Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] refactor bulletin impl code #2714

Merged
merged 1 commit into from
Sep 14, 2024
Merged

[improve] refactor bulletin impl code #2714

merged 1 commit into from
Sep 14, 2024

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Sep 14, 2024

What's changed?

need to drop the hzb_bulletin table in db and restart

update readme and png

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 requested a review from zqr10159 September 14, 2024 15:11
@github-actions github-actions bot added doc Improvements or additions to documentation backend webapp labels Sep 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.71429% with 27 lines in your changes missing coverage. Please review.

Project coverage is 32.00%. Comparing base (f5a8ebe) to head (8afca6c).

Files with missing lines Patch % Lines
...beat/manager/service/impl/BulletinServiceImpl.java 34.48% 12 Missing and 7 partials ⚠️
.../entity/manager/JsonMapListAttributeConverter.java 0.00% 4 Missing ⚠️
...rtzbeat/manager/controller/BulletinController.java 62.50% 3 Missing ⚠️
...ache/hertzbeat/common/entity/manager/Bulletin.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2714      +/-   ##
============================================
- Coverage     32.04%   32.00%   -0.05%     
+ Complexity     1693     1692       -1     
============================================
  Files           407      406       -1     
  Lines         16470    16438      -32     
  Branches       2130     2134       +4     
============================================
- Hits           5278     5261      -17     
+ Misses        10557    10539      -18     
- Partials        635      638       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zqr10159 zqr10159 merged commit a34ccdd into master Sep 14, 2024
5 checks passed
@zqr10159 zqr10159 deleted the dedoded2 branch September 14, 2024 16:41
@zuobiao-zhou zuobiao-zhou mentioned this pull request Sep 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend doc Improvements or additions to documentation webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants