Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimize] In a minor issue, the values of max and min are reversed #2678

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

lixiaobaivv
Copy link
Contributor

  • The SQL query is reversed from the actual value;

23png

23

…the performance metrics page, and the minimum value was taken for max and the maximum value for min
@lixiaobaivv lixiaobaivv changed the title In a minor issue, the values of max and min are reversed [optimize] In a minor issue, the values of max and min are reversed Sep 5, 2024
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if it's possible to add new unit tests to cover those cases. And thanks for your time.

@yuluo-yx
Copy link
Contributor

yuluo-yx commented Sep 5, 2024

I'm wondering if it's possible to add new unit tests to cover those cases. And thanks for your time.

+1, good idea.

@lixiaobaivv
Copy link
Contributor Author

我想知道是否可以添加新的单元测试来涵盖这些情况。谢谢您的宝贵时间。

+1,好主意。

Sorry, this is my first time submitting a PR. If there is anything wrong, I will improve it. Here is a screenshot of my unit test passing!
3

@LinuxSuRen
Copy link
Contributor

You can add some new unit tests to make sure your changes are correct. We do this because there are no testers to test the new changes.

Of course, this is only my personal suggestion. The maintainers might make the merge decision.

@lixiaobaivv
Copy link
Contributor Author

您可以添加一些新的单元测试来确保您的更改正确无误。我们这样做是因为没有测试人员来测试新的更改。

当然,这只是我的个人建议。维护者可能会做出合并决定。

Hello, when I was writing unit tests, I found that there was already a reusable test method. I tested the getMetricHistoryData method under the MetricsDataControllerTest class and it passed.

4

@zqr10159 zqr10159 merged commit e9bfee6 into apache:master Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants