Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Implement custom parameters for plugins #2616

Merged
merged 19 commits into from
Aug 29, 2024
Merged

Conversation

Yanshuming1
Copy link
Member

Implement custom parameters for plug-ins

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 19.76744% with 69 lines in your changes missing coverage. Please review.

Project coverage is 28.53%. Comparing base (6074c08) to head (bf5404a).
Report is 106 commits behind head on master.

Files with missing lines Patch % Lines
...tzbeat/manager/service/impl/PluginServiceImpl.java 24.61% 46 Missing and 3 partials ⚠️
...apache/hertzbeat/manager/pojo/dto/PluginParam.java 9.09% 10 Missing ⚠️
...hertzbeat/manager/pojo/dto/PluginParametersVO.java 0.00% 5 Missing ⚠️
...hertzbeat/manager/controller/PluginController.java 0.00% 4 Missing ⚠️
...eat/manager/component/alerter/DispatcherAlarm.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2616      +/-   ##
============================================
- Coverage     28.57%   28.53%   -0.05%     
- Complexity     1628     1630       +2     
============================================
  Files           440      442       +2     
  Lines         18003    18082      +79     
  Branches       2327     2334       +7     
============================================
+ Hits           5145     5159      +14     
- Misses        12273    12334      +61     
- Partials        585      589       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomsun28 tomsun28 requested a review from LiuTianyou August 27, 2024 15:34
@LiuTianyou
Copy link
Contributor

@Yanshuming1 If click the Edit button, an error message will pop up and the page will become unresponsive.
image

image

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2389 files.

Valid Invalid Ignored Fixed
1112 1 1276 0
Click to see the invalid file list
  • plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

@zqr10159 zqr10159 changed the title [feature] Implement custom parameters for plug-ins [feature] Implement custom parameters for plugins Aug 29, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2389 files.

Valid Invalid Ignored Fixed
1112 1 1276 0
Click to see the invalid file list
  • plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2389 files.

Valid Invalid Ignored Fixed
1112 1 1276 0
Click to see the invalid file list
  • plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2396 files.

Valid Invalid Ignored Fixed
1115 1 1280 0
Click to see the invalid file list
  • plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Copy link
Contributor

@LiuTianyou LiuTianyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LiuTianyou LiuTianyou merged commit 0e49e10 into master Aug 29, 2024
4 checks passed
@zqr10159 zqr10159 deleted the plugin-custom branch September 2, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants