-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Implement custom parameters for plugins #2616
Conversation
Co-authored-by: shown <[email protected]> Co-authored-by: Kerwin Bryant <[email protected]>
Co-authored-by: shown <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2616 +/- ##
============================================
- Coverage 28.57% 28.53% -0.05%
- Complexity 1628 1630 +2
============================================
Files 440 442 +2
Lines 18003 18082 +79
Branches 2327 2334 +7
============================================
+ Hits 5145 5159 +14
- Misses 12273 12334 +61
- Partials 585 589 +4 ☔ View full report in Codecov by Sentry. |
manager/src/main/java/org/apache/hertzbeat/manager/controller/PluginController.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/org/apache/hertzbeat/manager/service/PluginService.java
Show resolved
Hide resolved
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/PluginServiceImpl.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/PluginServiceImpl.java
Outdated
Show resolved
Hide resolved
manager/src/main/java/org/apache/hertzbeat/manager/service/impl/PluginServiceImpl.java
Show resolved
Hide resolved
@Yanshuming1 If click the Edit button, an error message will pop up and the page will become unresponsive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2389 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1112 | 1 | 1276 | 0 |
Click to see the invalid file list
- plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2389 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1112 | 1 | 1276 | 0 |
Click to see the invalid file list
- plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2389 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1112 | 1 | 1276 | 0 |
Click to see the invalid file list
- plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 2396 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1115 | 1 | 1280 | 0 |
Click to see the invalid file list
- plugin/src/main/resources/define/define.yml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Signed-off-by: liutianyou <[email protected]>
Signed-off-by: liutianyou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Implement custom parameters for plug-ins