Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imporve] null judge modify. #2558

Merged
merged 10 commits into from
Aug 27, 2024
Merged

[imporve] null judge modify. #2558

merged 10 commits into from
Aug 27, 2024

Conversation

MRgenial
Copy link
Contributor

What's changed?

Checklist

null judge modify.

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

yuluo-yx
yuluo-yx previously approved these changes Aug 19, 2024
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MRgenial

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yuluo-yx
Copy link
Contributor

LGTM.

@Calvin979 @tomsun28 pls ptal, if no other question, I will merge to main branch.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check passed. 👍 It is recommended that we can deploy and check the modified functions again by using nightly docker image https://hub.docker.com/r/apache/hertzbeat/tags

@tomsun28 tomsun28 merged commit 6117396 into apache:master Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants