Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix alarm threshold ava can not modify #2494

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Aug 8, 2024

What's changed?

close #2493

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the cascade values have been changed first, and recover later, and then click submit . the form can bu submiited. simplely check the cascade values length may can not slove the problem

@Aias00
Copy link
Contributor

Aias00 commented Aug 8, 2024

image when click submit button first time, the cascade values length is 2 and qbdata is empty; image image

modify the cascade value, make it`s length 3, then add a empty rule , it can be submitted successfully, and the rule value will be undifined actually

image

do not remove this empty rule , just change cascade values, and the form can be submitted successfully this time.

@tomsun28
Copy link
Contributor Author

tomsun28 commented Aug 8, 2024

hi, sorry for not got it. Do you means the empty rule should be verification failed, the form can not be submiited.? This maybe an another bug.

The cascade values length only mapping with the Metric Target Switch, if choose the Availability, cascade length is 2, if choose others metrics, length is 3.

image image

@Aias00
Copy link
Contributor

Aias00 commented Aug 8, 2024

hi, sorry for not got it. Do you means the empty rule should be verification failed, the form can not be submiited.? This maybe an another bug.

The cascade values length only mapping with the Metric Target Switch, if choose the Availability, cascade length is 2, if choose others metrics, length is 3.

image image

yeap, this empty rule can submitted successfully situation may be another bug. all i want to say, it`s that :

  1. if u changed the cascade value to 3 length、add some rule and then change it back to 2 length. it can be submitted; cause the rules datas were not cleared. and this can let the form check control valid. oh, this may be another bug 🤣
  2. when 2 length cascade , the form check control should allows the form`s submiting. and this pr can fix it appropriately

Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28
Copy link
Contributor Author

tomsun28 commented Aug 8, 2024

  • if u changed the cascade value to 3 length、add some rule and then change it back to 2 length. it can be submitted; cause the rules datas were not cleared. and this can let the form check control valid. oh, this may be another bug 🤣

Got it thanks, i will fix it.

@tomsun28 tomsun28 requested a review from kerwin612 August 9, 2024 05:06
@kerwin612 kerwin612 merged commit aeac1ff into master Aug 9, 2024
3 checks passed
@zqr10159 zqr10159 deleted the bugfix-threold branch September 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <Can not Edit Threshold Rule in master code>
3 participants