Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] : Use constant #2458

Merged
merged 7 commits into from
Aug 5, 2024
Merged

[improve] : Use constant #2458

merged 7 commits into from
Aug 5, 2024

Conversation

Yanshuming1
Copy link
Member

Use constant

@Yanshuming1 Yanshuming1 added the good first issue Good for newcomers label Aug 4, 2024
@Yanshuming1 Yanshuming1 added good first pull request Good for newcomers improve and removed good first issue Good for newcomers collector labels Aug 4, 2024
yuluo-yx
yuluo-yx approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28 tomsun28 merged commit 9ac45ab into apache:master Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend collector good first pull request Good for newcomers improve
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yanshuming1 @tomsun28 @yuluo-yx