[Improve] add AlertDefineExcel unit test and fix bugs #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuluo-yx
commented
Jul 25, 2024
| @@ -82,6 +82,12 @@ | |||
| <version>4.1.1</version> | |||
| <scope>compile</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
@tomsun28 if not add this dependency, writeOS method will not work. so I add it. any ideas?
There was a problem hiding this comment.
hi, the poi-oomxl has been added in licenses doc, you can add it here.
for alarm define excel export, maybe can refer the monitors execl export import
yuluo-yx
commented
Jul 25, 2024
| @@ -105,47 +100,4 @@ protected String fileNamePrefix() { | |||
| return "hertzbeat_alertDefine_" + LocalDate.now(); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I will move to dto pkg.
Signed-off-by: yuluo-yx <[email protected]>
…tzbeat into 0725-yuluo/add-test
1 task
Signed-off-by: yuluo-yx <[email protected]>
Signed-off-by: yuluo-yx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add AlertDefineExcel unit test and fix bugs