Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Unable to specify collector when creating a monitor #2311

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Jul 18, 2024

What's changed?

Link issue: #2300
Test result:
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

tomsun28
tomsun28 previously approved these changes Jul 19, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm👍 close #2300

@tomsun28 tomsun28 requested a review from kerwin612 July 19, 2024 08:31
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 19, 2024
@tomsun28 tomsun28 linked an issue Jul 20, 2024 that may be closed by this pull request
1 task
@kerwin612 kerwin612 dismissed their stale review July 24, 2024 03:24

The submitter has not responded for a long time

@kerwin612 kerwin612 merged commit f4685aa into apache:master Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to specify collector when creating a monitor
4 participants