Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small code specification change. #2299

Merged
merged 3 commits into from
Jul 17, 2024
Merged

A small code specification change. #2299

merged 3 commits into from
Jul 17, 2024

Conversation

TJxiaobao
Copy link
Contributor

What's changed?

A small code specification change.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@TJxiaobao TJxiaobao requested a review from tomsun28 July 17, 2024 09:49
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.26%. Comparing base (38d466b) to head (10a0406).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2299      +/-   ##
============================================
- Coverage     20.27%   20.26%   -0.02%     
  Complexity     1103     1103              
============================================
  Files           405      405              
  Lines         17204    17205       +1     
  Branches       2270     2270              
============================================
- Hits           3488     3486       -2     
- Misses        13329    13332       +3     
  Partials        387      387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍lgtm!

@zqr10159 zqr10159 merged commit 07913e7 into master Jul 17, 2024
3 checks passed
@zqr10159 zqr10159 deleted the notice_template_fix branch July 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants