Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed failure of alert form validation #2259

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Fixed failure of alert form validation #2259

merged 4 commits into from
Jul 10, 2024

Conversation

kerwin612
Copy link
Member

What's changed?

before：
before

after：
after

Fixed failure of alert form validation

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

tomsun28
tomsun28 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 lgtm

@tomsun28
Copy link
Contributor

hi, about the alarm threshold expression. Should we support the and or ?, like this cloudflare config

image

@kerwin612
Copy link
Member Author

hi, about the alarm threshold expression. Should we support the and or ?, like this cloudflare config

image

Great, perfect! I'll do this support after I finish all the global form problems.

@tomsun28 tomsun28 merged commit 8f91430 into apache:master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerwin612 @tomsun28