Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]update doc for custom plugin #2245

Merged
merged 10 commits into from
Aug 31, 2024

Conversation

LiuTianyou
Copy link
Contributor

@LiuTianyou LiuTianyou commented Jul 8, 2024

What's changed?

  1. update doc for custom plugin [Task] Plugin hot reloading. #2173

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Jul 8, 2024
@tomsun28 tomsun28 requested a review from zqr10159 July 8, 2024 14:24
@zqr10159
Copy link
Member

zqr10159 commented Jul 8, 2024

Lgtm,but I suggest to merge it after the new version is released to avoid user misundersting, or how about we provide dev docs 和 release docs? @tomsun28

@tomsun28
Copy link
Contributor

tomsun28 commented Jul 8, 2024

Lgtm,but I suggest to merge it after the new version is released to avoid user misundersting, or how about we provide dev docs 和 release docs? @tomsun28

ok, we can merge it when new version released.

@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 8, 2024
zqr10159
zqr10159 previously approved these changes Aug 27, 2024
@zqr10159
Copy link
Member

@LiuTianyou Please resolve conflicts,I will merge it later.

@LiuTianyou
Copy link
Contributor Author

@zqr10159 hi,I resolved the conflict and modified the documentation according to the latest plugin implementation

@zqr10159
Copy link
Member

@zqr10159 hi,I resolved the conflict and modified the documentation according to the latest plugin implementation

lgtm!

@zqr10159 zqr10159 merged commit 2763ee4 into apache:master Aug 31, 2024
3 checks passed
@LiuTianyou LiuTianyou deleted the doc-plugin-management branch August 31, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers wait for process
Projects
Development

Successfully merging this pull request may close these issues.

3 participants