Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add plugin management and support plugin hot reloading #2238

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. add plugin management
  2. support plugin hot reloading ([Task] Plugin hot reloading. #2173 )
  3. support plugin disabling and enabling

plugin-1
plugin-2

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@LiuTianyou
Copy link
Contributor Author

I will add relevant documentation in the next PR

@tomsun28 tomsun28 requested a review from zqr10159 July 8, 2024 02:34
@zqr10159
Copy link
Member

zqr10159 commented Jul 8, 2024

Please fix eslint errors
Linting "hertzbeat-web-app"...

/home/runner/work/hertzbeat/hertzbeat/web-app/src/app/routes/setting/plugins/plugin.component.html
29:13 个错误 Delete · prettier/prettier
138:17 个错误 Replace 'common.file.select'|i18n with ·'common.file.select'·|·i18n· prettier/prettier

✖ 2 problems (2 个错误, 0 warnings)
2 个错误 和 0 warnings potentially fixable with the --fix option.

Lint errors found in the listed files.

@zqr10159
Copy link
Member

zqr10159 commented Jul 8, 2024

lgtm!

@zqr10159 zqr10159 merged commit 2d53abd into apache:master Jul 8, 2024
4 checks passed
@LiuTianyou LiuTianyou deleted the feat-hot-load-plugin branch July 8, 2024 13:00
@pwallk pwallk mentioned this pull request Jul 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants