Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] add @Override #2224

Merged
merged 1 commit into from
Jul 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public class FtpCollectImpl extends AbstractCollect {
/**
* preCheck params
*/
@Override
public void preCheck(Metrics metrics) throws IllegalArgumentException{
if (metrics == null || metrics.getFtp() == null) {
throw new IllegalArgumentException("Ftp collect must has ftp params.");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public MongodbSingleCollectImpl() {
/**
* Check that the mongodb connection information in metrics is complete
*/
@Override
public void preCheck(Metrics metrics) throws IllegalArgumentException{
Assert.isTrue(metrics != null && metrics.getMongodb() != null, "Mongodb collect must has mongodb params");
MongodbProtocol mongodbProtocol = metrics.getMongodb();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public void destroy() {
* preCheck params
* @param metrics metrics config
*/
@Override
public void preCheck(Metrics metrics) throws IllegalArgumentException {
Assert.isTrue(metrics != null && metrics.getRocketmq() != null, "Mongodb collect must has rocketmq params");
RocketmqProtocol rocketmq = metrics.getRocketmq();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public RedisCommonCollectImpl() {
connectionCommonCache = new ConnectionCommonCache<>();
}

@Override
public void preCheck(Metrics metrics) throws IllegalArgumentException{
Assert.noNullElements(new Object[] {metrics, metrics.getRedis()}, "Redis collect must has redis params");
RedisProtocol redisProtocol = metrics.getRedis();
Expand Down
Loading