[Improve] Refactor the notification sending logic. #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support jacoco and Codecov
# Conflicts: # collector/src/test/java/org/apache/hertzbeat/collector/util/JsonPathParserTest.java
# Conflicts: # pom.xml
tomsun28
reviewed
Jul 4, 2024
| matchNoticeRulesByAlert(alert).ifPresent(noticeRules -> { | ||
| noticeRules.forEach(rule -> { | ||
| workerPool.executeNotify(() -> { | ||
| rule.getReceiverId().stream().filter(receiverId -> rule.getTemplateId() != null) |
There was a problem hiding this comment.
hi, the code logic here is to filter out cases where the template id is null, but before the template id was null it would go to use the default file notification template.
There was a problem hiding this comment.
Thank you for the reminder. I adjusted the logic;
I moved the template query earlier so it can return exceptions faster, and the code can be more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the notification sending logic.
I noticed that most of the
AlertNotifyHandlersrequire the use ofNoticeTemplate, so I directly filtered out the data with nulltemplateId, making the code more concise.Checklist
Add or update API