Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for password type to the app-multi-func-input component. #2132

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Add support for password type to the app-multi-func-input component. #2132

merged 4 commits into from
Jun 25, 2024

Conversation

kerwin612
Copy link
Member

What's changed?

Replace the repeated template code for the password component with the common base component app-multi-func-input.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jun 25, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 25, 2024
tomsun28
tomsun28 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@tomsun28 tomsun28 merged commit 87756f1 into apache:master Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers webapp
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kerwin612 @tomsun28