Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an input box component with a removal function. #2127

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

kerwin612
Copy link
Member

What's changed?

1719207867154
Replace the two input components in the monitoring center with input components that have a allowClear function, so that they are consistent with the select components in supporting quick clear of filter values.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍lgtm

@tomsun28 tomsun28 merged commit 657de4f into apache:master Jun 24, 2024
3 checks passed
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 24, 2024
kerwin612 added a commit to kerwin612/hertzbeat that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants