[bug]fix the monitor status is abnormal #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #2062 |
|
hi, this relates the common alarm part. Please wait that we need time to conduct a detailed test, review. |
tomsun28
approved these changes
Jun 24, 2024
Comment on lines
+58
to
+59
| if ((currentAlert.getTags() != null && currentAlert.getTags().containsKey(CommonConstants.IGNORE)) | ||
| || currentAlert.getStatus() == CommonConstants.ALERT_STATUS_CODE_RESTORED) { |
There was a problem hiding this comment.
Suggested change
| if ((currentAlert.getTags() != null && currentAlert.getTags().containsKey(CommonConstants.IGNORE)) | |
| || currentAlert.getStatus() == CommonConstants.ALERT_STATUS_CODE_RESTORED) { | |
| if (currentAlert.getStatus() == CommonConstants.ALERT_STATUS_CODE_RESTORED) { |
status always is the ALERT_STATUS_CODE_RESTORED when tags has CommonConstants.IGNORE
There was a problem hiding this comment.
In both cases, the data in the map needs to be deleted，if remove （|| currentAlert . getStatus () == CommonConstants . ALERT_STATUS_CODE_RESTORED ），So when the label is not IGNORE，Unable to clear cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the monitor status is abnormal