Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] change package group to org apache hertzbeat #1724

Merged
merged 7 commits into from
Apr 9, 2024
Merged

[Improve] change package group to org apache hertzbeat #1724

merged 7 commits into from
Apr 9, 2024

Conversation

leo-934
Copy link
Contributor

@leo-934 leo-934 commented Apr 9, 2024 •
edited
Loading

change package name to org.apache.hertzbeat
add apache project metadata.
remove annotations in comments.
delete unused md.

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

leo-934 added 2 commits April 9, 2024 17:43
@leo-934
change package name to org.apache.hertzbeat.
0467ba9 
remove annotations in comments.
@leo-934
change package name to org.apache.hertzbeat.
c060c3e 
remove annotations in comments.
@leo-934 leo-934 requested a review from tomsun28 April 9, 2024 10:02
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 9, 2024
zqr10159
zqr10159 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomsun28
add repo metadata
ebf8f27 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28 tomsun28 changed the title change package name to org.apache.hertzbeat change package group to org apache hertzbeat Apr 9, 2024
tomsun28 added 3 commits April 9, 2024 22:04
@tomsun28
remove unused md
38bfe09 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28
delete unused md
d39ffec 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28
remove unused
ca77cce 
Signed-off-by: tomsun28 <[email protected]>
@tomsun28 tomsun28 changed the title change package group to org apache hertzbeat [Improve] change package group to org apache hertzbeat Apr 9, 2024
@tomsun28
update email
4305802 
Signed-off-by: tomsun28 <[email protected]>
tomsun28
tomsun28 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍
updated: add apache project metadata, delete unused md

@leo-934 leo-934 merged commit 48e2ac0 into master Apr 9, 2024
2 checks passed
tomsun28 added a commit that referenced this pull request Apr 9, 2024
@leo-934 @tomsun28
[Improve] migrate to apache(#1724)
47793f7 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
@zqr10159 zqr10159 deleted the fix#format branch September 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqr10159 zqr10159 zqr10159 approved these changes

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-934 @tomsun28 @zqr10159