Refactor: using Reflections to load AbstractCollect #1681
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Hertzbeat uses SPI to load AbstractCollect, which means anybody who intends to add a new monitor needs to modify SPI file(in the path
META-INF\services
) as well.Therefore I use Reflections to replace SPI. It will scan concrete class of AbstractCollect and create instance automatically.
New Dependency
Checklist
Add or update API