Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager check style modify #1592

Merged
merged 2 commits into from
Feb 28, 2024
Merged

manager check style modify #1592

merged 2 commits into from
Feb 28, 2024

Conversation

yqxxgh
Copy link
Contributor

@yqxxgh yqxxgh commented Feb 28, 2024

What's changed?

manager check style modify

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@yqxxgh yqxxgh added the enhancement New feature or request label Feb 28, 2024
@yqxxgh yqxxgh requested a review from tomsun28 February 28, 2024 13:14
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 28, 2024
tomsun28
tomsun28 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@tomsun28 tomsun28 merged commit accda62 into master Feb 28, 2024
2 checks passed
@tomsun28 tomsun28 deleted the checkstyle-manager branch February 28, 2024 14:54
@tomsun28 tomsun28 linked an issue Feb 29, 2024 that may be closed by this pull request
[Task] <fix and pass the checkstyle error in manager module code> #1579
Closed
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
d06395e 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
f96f0f6 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@yqxxgh @zqr10159 @tomsun28
manager check style modify (#1592)
67e621e 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
2f85127 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@yqxxgh @zqr10159 @tomsun28
manager check style modify (#1592)
8e446e7 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
30a4132 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
715c6f4 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
a8d18b8 
Co-authored-by: Logic <[email protected]>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@yqxxgh @zqr10159
manager check style modify (#1592)
411eb58 
Co-authored-by: Logic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <fix and pass the checkstyle error in manager module code>
3 participants
@yqxxgh @tomsun28 @zqr10159