Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]Fix and pass the checkstyle error in warehouse module code #1590

Merged
merged 2 commits into from
Feb 28, 2024
Merged

[fix]Fix and pass the checkstyle error in warehouse module code #1590

merged 2 commits into from
Feb 28, 2024

Conversation

zqr10159
Copy link
Member

What's changed?

#1580

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 28, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Feb 28, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Feb 28, 2024
@tomsun28
update
b7eecd7 
Signed-off-by: tomsun28 <[email protected]>
tomsun28
tomsun28 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@tomsun28 tomsun28 merged commit 7b970be into master Feb 28, 2024
2 checks passed
@tomsun28 tomsun28 deleted the checkstyle-warehouse branch February 28, 2024 03:45
a-little-fool pushed a commit that referenced this pull request Feb 28, 2024
@zqr10159 @tomsun28 @a-little-fool
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
cfd438b 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
a-little-fool pushed a commit that referenced this pull request Feb 28, 2024
@zqr10159 @tomsun28 @a-little-fool
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
1afc30f 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
c5d42c8 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
8da1c2b 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
9a269e6 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
a6d26d5 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
8ec21e9 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
fb3c2db 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
e450d20 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
0b24ec9 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@zqr10159 @tomsun28
[fix]Fix and pass the checkstyle error in warehouse module code (#1590)
024d2b4 
Signed-off-by: tomsun28 <[email protected]>
Co-authored-by: tomsun28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zqr10159 @tomsun28