Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and pass the checkstyle error in alerter module code #1589

Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix and pass the checkstyle error in alerter module code #1589

merged 3 commits into from
Feb 28, 2024

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Feb 28, 2024 •
edited
Loading

What's changed?

Related issues: #1576
image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 28, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Feb 28, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Feb 28, 2024
zqr10159
zqr10159 reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 28, 2024
@zqr10159 zqr10159 merged commit 850db1b into apache:master Feb 28, 2024
2 checks passed
@tomsun28 tomsun28 linked an issue Feb 29, 2024 that may be closed by this pull request
[Task] <fix and pass the checkstyle error in alerter module code> #1576
Closed
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
78b6e89
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
d61d428
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@ZY945 @tomsun28
fix and pass the checkstyle error in alerter module code (#1589)
a8da2fc
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
ce3a9b4
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@ZY945 @tomsun28
fix and pass the checkstyle error in alerter module code (#1589)
c5db9d5
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
2341572
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
2103053
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
0148c1b
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
fix and pass the checkstyle error in alerter module code (#1589)
e55db94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqr10159 zqr10159 zqr10159 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[Task] <fix and pass the checkstyle error in alerter module code>
3 participants
@ZY945 @zqr10159 @tomsun28