test: add more unit tests for some services (#2653)

Co-authored-by: rick <[email protected]> Co-authored-by: shown <[email protected]> Co-authored-by: Calvin <[email protected]> Co-authored-by: aias00 <[email protected]>
apache · Sep 3, 2024 · 86ca715 · 86ca715
1 parent 7b886fe
commit 86ca715
Show file tree

Hide file tree

Showing 7 changed files with 508 additions and 10 deletions.
diff --git a/.../src/test/java/org/apache/hertzbeat/collector/collect/database/JdbcCommonCollectTest.java b/.../src/test/java/org/apache/hertzbeat/collector/collect/database/JdbcCommonCollectTest.java
@@ -17,19 +17,115 @@
 
 package org.apache.hertzbeat.collector.collect.database;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.apache.hertzbeat.collector.dispatch.DispatchConstants;
+import org.apache.hertzbeat.common.entity.job.Metrics;
+import org.apache.hertzbeat.common.entity.job.protocol.JdbcProtocol;
+import org.apache.hertzbeat.common.entity.message.CollectRep;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 /**
  * Test case for {@link JdbcCommonCollect}
  */
 class JdbcCommonCollectTest {
+    private JdbcCommonCollect jdbcCommonCollect;
 
     @BeforeEach
-    void setUp() {
+    void setup() {
+        jdbcCommonCollect = new JdbcCommonCollect();
+    }
+
+    @Test
+    void preCheck() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            jdbcCommonCollect.preCheck(null);
+        });
+        assertThrows(IllegalArgumentException.class, () -> {
+            Metrics metrics = new Metrics();
+            jdbcCommonCollect.preCheck(metrics);
+        });
+
+        assertDoesNotThrow(() -> {
+            JdbcProtocol jdbc = new JdbcProtocol();
+            jdbc.setUrl("jdbc:mysql://localhost:3306/test");
+
+            Metrics metrics = new Metrics();
+            metrics.setJdbc(jdbc);
+            jdbcCommonCollect.preCheck(metrics);
+        });
+
+        String[] invalidKeywords = new String[]{
+            "allowLoadLocalInfile", "allowLoadLocalInfileInPath", "useLocalInfile"
+        };
+        for (String keyword : invalidKeywords) {
+            // contains not allowed keywords
+            assertThrows(IllegalArgumentException.class, () -> {
+                JdbcProtocol jdbc = new JdbcProtocol();
+                jdbc.setUrl("jdbc:mysql://localhost:3306/test?" + keyword);
+
+                Metrics metrics = new Metrics();
+                metrics.setJdbc(jdbc);
+                jdbcCommonCollect.preCheck(metrics);
+            });
+        }
+    }
+
+    @Test
+    void collect() {
+        assertDoesNotThrow(() -> {
+            JdbcProtocol jdbc = new JdbcProtocol();
+            jdbc.setUrl("jdbc:mysql://localhost:3306/test");
+            jdbc.setUsername("root");
+            jdbc.setPassword("123456");
+            jdbc.setQueryType("select");
+
+            Metrics metrics = new Metrics();
+            metrics.setJdbc(jdbc);
+
+            CollectRep.MetricsData.Builder builder = CollectRep.MetricsData.newBuilder();
+            jdbcCommonCollect.collect(builder, 1, "test", metrics);
+        });
+
+        String[] platforms = new String[]{
+            "mysql", "mariadb",
+            "postgresql",
+            "clickhouse",
+            "sqlserver",
+            "oracle",
+            "dm"
+        };
+        for (String platform : platforms) {
+            assertDoesNotThrow(() -> {
+                JdbcProtocol jdbc = new JdbcProtocol();
+                jdbc.setPlatform(platform);
+
+                Metrics metrics = new Metrics();
+                metrics.setJdbc(jdbc);
+
+                CollectRep.MetricsData.Builder builder = CollectRep.MetricsData.newBuilder();
+                jdbcCommonCollect.collect(builder, 1, "test", metrics);
+            });
+        }
+        // invalid platform
+        assertThrows(IllegalArgumentException.class, () -> {
+            JdbcProtocol jdbc = new JdbcProtocol();
+            jdbc.setPlatform("invalid");
+
+            Metrics metrics = new Metrics();
+            metrics.setJdbc(jdbc);
+
+            CollectRep.MetricsData.Builder builder = CollectRep.MetricsData.newBuilder();
+            jdbcCommonCollect.collect(builder, 1, "test", metrics);
+        });
     }
 
     @Test
-    void getInstance() {
+    void supportProtocol() {
+        String protocol = jdbcCommonCollect.supportProtocol();
+        assertEquals(DispatchConstants.PROTOCOL_JDBC, protocol);
     }
 }
diff --git a/collector/src/test/java/org/apache/hertzbeat/collector/collect/http/HttpCollectImplTest.java b/collector/src/test/java/org/apache/hertzbeat/collector/collect/http/HttpCollectImplTest.java
@@ -17,28 +17,52 @@
 
 package org.apache.hertzbeat.collector.collect.http;
 
-import org.junit.jupiter.api.AfterEach;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+import org.apache.hertzbeat.common.entity.job.Metrics;
+import org.apache.hertzbeat.common.entity.job.protocol.HttpProtocol;
+import org.apache.hertzbeat.common.entity.message.CollectRep;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 /**
  * Test case for {@link HttpCollectImpl}
  */
 class HttpCollectImplTest {
+    private HttpCollectImpl httpCollectImpl;
 
     @BeforeEach
     void setUp() {
+        httpCollectImpl = new HttpCollectImpl();
     }
 
-    @AfterEach
-    void tearDown() {
+    @Test
+    void preCheck() {
+        assertThrows(IllegalArgumentException.class, () -> {
+            httpCollectImpl.preCheck(null);
+        });
+
+        assertThrows(IllegalArgumentException.class, () -> {
+            Metrics metrics = Metrics.builder().build();
+            httpCollectImpl.preCheck(metrics);
+        });
     }
 
     @Test
-    void getInstance() {
+    void collect() {
+        HttpProtocol http = HttpProtocol.builder().build();
+        http.setMethod("POST");
+        Metrics metrics = Metrics.builder()
+                .http(http)
+                .build();
+        CollectRep.MetricsData.Builder builder = CollectRep.MetricsData.newBuilder();
+
+        httpCollectImpl.collect(builder, 1L, "app", metrics);
     }
 
     @Test
-    void collect() {
+    void supportProtocol() {
+        String protocol = httpCollectImpl.supportProtocol();
+        assert "http".equals(protocol);
     }
 }
diff --git a/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/BulletinServiceImpl.java b/manager/src/main/java/org/apache/hertzbeat/manager/service/impl/BulletinServiceImpl.java
@@ -215,8 +215,8 @@ public BulletinMetricsData buildBulletinMetricsData(BulletinMetricsData.Bulletin
                         fieldsList = Collections.singletonList(fields.stream()
                                 .map(field -> BulletinMetricsData.Field.builder()
                                         .key(field)
-                                        .unit("")
-                                        .value("NO_DATA")
+                                        .unit(EMPTY_STRING)
+                                        .value(NO_DATA)
                                         .build())
                                 .toList());
                     }

diff --git a/manager/src/test/java/org/apache/hertzbeat/manager/scheduler/CollectorJobSchedulerTest.java b/manager/src/test/java/org/apache/hertzbeat/manager/scheduler/CollectorJobSchedulerTest.java
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hertzbeat.manager.scheduler;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.when;
+
+import org.apache.hertzbeat.common.entity.message.CollectRep;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.hertzbeat.common.entity.job.Job;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+/**
+ * Test case for {@link CollectorJobScheduler}
+ */
+@ExtendWith(MockitoExtension.class)
+public class CollectorJobSchedulerTest {
+    @InjectMocks
+    private CollectorJobScheduler collectorJobScheduler;
+    @Mock
+    private ConsistentHash consistentHash;
+
+    @Test
+    public void testCollectSyncJobData() {
+        assertDoesNotThrow(() -> {
+            Job job = new Job();
+            when(consistentHash.preDispatchJob(any(String.class))).thenReturn(null);
+            List<?> list = collectorJobScheduler.collectSyncJobData(job);
+            assertEquals(1, list.size());
+        });
+    }
+
+    @Test
+    public void testCollectSyncJobResource() {
+        assertDoesNotThrow(() -> {
+            collectorJobScheduler.collectSyncJobResponse(null);
+            collectorJobScheduler.collectSyncJobResponse(new ArrayList<>());
+
+            List<CollectRep.MetricsData> metricsDataList = new ArrayList<CollectRep.MetricsData>();
+            metricsDataList.add(CollectRep.MetricsData.newBuilder().build());
+            collectorJobScheduler.collectSyncJobResponse(metricsDataList);
+        });
+    }
+}