Further enhance and refine the optimizations implemented in #2215. (#…

…2249) Signed-off-by: Kerwin Bryant <[email protected]>
apache · Jul 9, 2024 · 6cabe3c · 6cabe3c
1 parent 874f7bd
commit 6cabe3c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.html
@@ -58,11 +58,7 @@
         />
       </ng-container>
 
-      <nz-collapse
-        *ngIf="advancedParamDefines && advancedParamDefines.length > 0"
-        [nzGhost]="true"
-        style="background: ghostwhite; margin-bottom: 24px"
-      >
+      <nz-collapse *ngIf="hasAdvancedParams" [nzGhost]="true" style="background: ghostwhite; margin-bottom: 24px">
         <ng-template #extraColHeader>
           <button style="margin-left: 40%" nz-button nzType="dashed" nz-tooltip [nzTooltipTitle]="'monitors.advanced.tip' | i18n">
             <span>{{ 'monitors.advanced' | i18n }}</span>

diff --git a/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts b/web-app/src/app/routes/monitor/monitor-form/monitor-form.component.ts
@@ -47,9 +47,19 @@ export class MonitorFormComponent implements OnChanges {
   @Output() readonly formDetect = new EventEmitter<any>();
   @Output() readonly hostChange = new EventEmitter<string>();
 
+  hasAdvancedParams: boolean = false;
+
   constructor() {}
 
   ngOnChanges(changes: SimpleChanges) {
+    if (changes.advancedParams && changes.advancedParams.currentValue !== changes.advancedParams.previousValue) {
+      for (const advancedParam of changes.advancedParams.currentValue) {
+        if (advancedParam.display !== false) {
+          this.hasAdvancedParams = true;
+          break;
+        }
+      }
+    }
     if (changes.paramDefines && changes.paramDefines.currentValue !== changes.paramDefines.previousValue) {
       changes.paramDefines.currentValue.forEach((paramDefine: any) => {
         if (paramDefine.type == 'radio') {