-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23205 Correctly update the position of WALs currently being replicated (2) #944
Conversation
@wchevreuil I squashed my commits and made a new PR |
032b63f
to
35f0a8d
Compare
@wchevreuil It seems pre-commit hook was not triggered again. I have no idea what conditions should be required to trigger it. |
Thanks @JeongDaeKim , it's actually crashing at the beginning due to same error from previous PR: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-944/3/console. Let me try figure why this happens. |
35f0a8d
to
4b984e1
Compare
4b984e1
to
fb62e8e
Compare
💔 -1 overall
This message was automatically generated. |
Rebased and force-pushed twice to trigger pre-commit hook, and somehow it worked finally. I checked failed tests
another build is running now because of my two pushes (https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-944/5/),and it will produce the same result as the previous build 4. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failures seems unrelated. +1.
Thanks @JeongDaeKim for pointing out test failures, these happen on branch-1 since we have null initialization for list of store files as opposed to empty lists in master and branch-2. |
https://issues.apache.org/jira/browse/HBASE-23205
#749 (comment)