Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time [Take2] #748

Merged

Conversation

bitterfox
Copy link
Contributor

https://builds.apache.org/job/HBase Nightly/job/branch-1/1114//testReport/junit/org.apache.hadoop.hbase.master/TestCatalogJanitor/health_checks___yetus_jdk8_hadoop2_checks___testCleanParent/

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 43m 50s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
💚 mvninstall 9m 8s branch-1 passed
💚 compile 0m 48s branch-1 passed with JDK v1.8.0_232
💚 compile 0m 55s branch-1 passed with JDK v1.7.0_242
💚 checkstyle 1m 54s branch-1 passed
💚 shadedjars 3m 40s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 43s branch-1 passed with JDK v1.8.0_232
💚 javadoc 0m 48s branch-1 passed with JDK v1.7.0_242
💙 spotbugs 3m 31s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 3m 26s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 2m 35s the patch passed
💚 compile 0m 49s the patch passed with JDK v1.8.0_232
💚 javac 0m 49s the patch passed
💚 compile 0m 58s the patch passed with JDK v1.7.0_242
💚 javac 0m 58s the patch passed
💚 checkstyle 1m 51s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 3m 32s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 58s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 35s the patch passed with JDK v1.8.0_232
💚 javadoc 0m 48s the patch passed with JDK v1.7.0_242
💚 findbugs 3m 29s the patch passed
_ Other Tests _
💔 unit 197m 9s hbase-server in the patch failed.
💚 asflicense 0m 35s The patch does not generate ASF License warnings.
287m 56s
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterBalanceThrottling
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.client.TestAdmin2
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/1/artifact/out/Dockerfile
GITHUB PR #748
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8f220407ea6b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-748/out/precommit/personality/provided.sh
git revision branch-1 / ce65db3
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/1/testReport/
Max. process+thread count 4296 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bitterfox
Copy link
Contributor Author

Cannot reproduce all test failures above locally
Screenshot from 2019-10-24 12-36-34
Screenshot from 2019-10-24 12-35-16
Screenshot from 2019-10-24 12-26-01
Screenshot from 2019-10-24 12-23-15

@bitterfox bitterfox force-pushed the HBASE-23185-branch-1-fix-test-failure branch from e98c2ea to 45c7e35 Compare October 29, 2019 09:17
@bitterfox bitterfox changed the title HBASE-23185 Fix test failure by HBASE-23185 changes HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time [Take2] Oct 29, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 16m 57s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
💙 mvndep 1m 22s Maven dependency ordering for branch
💚 mvninstall 7m 21s branch-1 passed
💚 compile 1m 0s branch-1 passed with JDK v1.8.0_232
💚 compile 1m 7s branch-1 passed with JDK v1.7.0_242
💚 checkstyle 2m 7s branch-1 passed
💚 shadedjars 2m 48s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 54s branch-1 passed with JDK v1.8.0_232
💚 javadoc 1m 8s branch-1 passed with JDK v1.7.0_242
💙 spotbugs 2m 39s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 4m 4s branch-1 passed
_ Patch Compile Tests _
💙 mvndep 0m 16s Maven dependency ordering for patch
💚 mvninstall 1m 57s the patch passed
💚 compile 0m 58s the patch passed with JDK v1.8.0_232
💚 javac 0m 58s the patch passed
💚 compile 1m 9s the patch passed with JDK v1.7.0_242
💚 javac 1m 9s the patch passed
💚 checkstyle 0m 38s hbase-client: The patch generated 0 new + 142 unchanged - 1 fixed = 142 total (was 143)
💚 checkstyle 1m 30s The patch passed checkstyle in hbase-server
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 46s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 4s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 49s the patch passed with JDK v1.8.0_232
💚 javadoc 1m 7s the patch passed with JDK v1.7.0_242
💚 findbugs 4m 23s the patch passed
_ Other Tests _
💚 unit 2m 40s hbase-client in the patch passed.
💚 unit 144m 19s hbase-server in the patch passed.
💚 asflicense 0m 51s The patch does not generate ASF License warnings.
211m 11s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/2/artifact/out/Dockerfile
GITHUB PR #748
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c4b7224e7505 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-748/out/precommit/personality/provided.sh
git revision branch-1 / 93a97ca
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/2/testReport/
Max. process+thread count 3981 (vs. ulimit of 10000)
modules C: hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-748/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit 3c7c1b5 into apache:branch-1 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants