Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23152 Compaction_switch does not work by RegionServer name #713

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

karthikhw
Copy link
Contributor

@karthikhw karthikhw commented Oct 11, 2019

Compaction_switch is used to stop running compaction on regionservers. This switch works good by using "compaction_switch true/false" but rather I want to stop compaction only for particular regionserver. In that case, the switch doesn't work because serverName that we want to stop is not added into CompletableFuture<List<ServerName>>. So we always get empty Future list by using RS name.

https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java#L3156

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 22s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💙 mvndep 0m 36s Maven dependency ordering for branch
💚 mvninstall 6m 17s master passed
💚 compile 2m 1s master passed
💚 checkstyle 2m 21s master passed
💚 shadedjars 5m 21s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 27s master passed
💙 spotbugs 5m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 39s master passed
_ Patch Compile Tests _
💙 mvndep 0m 19s Maven dependency ordering for patch
💚 mvninstall 5m 46s the patch passed
💚 compile 1m 50s the patch passed
💚 javac 1m 50s the patch passed
💚 checkstyle 2m 18s the patch passed
💚 rubocop 0m 4s There were no new rubocop issues.
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 5m 19s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 18m 10s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚 javadoc 1m 14s the patch passed
💚 findbugs 7m 7s the patch passed
_ Other Tests _
💚 unit 2m 1s hbase-client in the patch passed.
💔 unit 284m 44s hbase-server in the patch failed.
💚 unit 9m 29s hbase-shell in the patch passed.
💚 asflicense 1m 14s The patch does not generate ASF License warnings.
373m 18s
Reason Tests
Failed junit tests hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
hadoop.hbase.master.TestMasterShutdown
Subsystem Report/Notes
Docker Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/artifact/out/Dockerfile
GITHUB PR #713
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile rubocop
uname Linux 6df9040452f7 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-713/out/precommit/personality/provided.sh
git revision master / 1aee5f0
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/testReport/
Max. process+thread count 5084 (vs. ulimit of 10000)
modules C: hbase-client hbase-server hbase-shell U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-713/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.75.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit c0a09cc into apache:master Oct 12, 2019
asfgit pushed a commit that referenced this pull request Oct 12, 2019
asfgit pushed a commit that referenced this pull request Oct 12, 2019
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
…che#713)

 Signed-off-by: Duo Zhang <[email protected]>
 Signed-off-by: stack <[email protected]>
(cherry picked from commit 5d5cf90)

Change-Id: Idb83721e54fbebda41af9aba963cd14790f20fc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants