Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23128 Restore Region interface compatibility #694

Closed
wants to merge 1 commit into from

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Oct 7, 2019

Restore and deprecate Region#bulkLoadHFiles(Collection<Pair<byte[],String>>, boolean,
Region.BulkLoadListener).
Warn if invoked.

Restore and deprecate Region#bulkLoadHFiles(Collection<Pair<byte[],String>>, boolean,
  Region.BulkLoadListener).
Warn if invoked.
@apurtell apurtell requested a review from wchevreuil October 7, 2019 19:25
@apurtell
Copy link
Contributor Author

apurtell commented Oct 7, 2019

I'm going to merge this as soon as the compat report verifies the issue with Region is fixed so I can get out the 1.5.0 RC4 but we can always circle back if there's something that needs changing.

@apurtell apurtell closed this Oct 7, 2019
@apurtell apurtell deleted the HBASE-23128-branch-1 branch October 7, 2019 19:37
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
💚 mvninstall 8m 22s branch-1 passed
💚 compile 0m 42s branch-1 passed with JDK v1.8.0_222
💚 compile 0m 48s branch-1 passed with JDK v1.7.0_232
💚 checkstyle 1m 53s branch-1 passed
💚 shadedjars 3m 7s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 37s branch-1 passed with JDK v1.8.0_222
💚 javadoc 0m 40s branch-1 passed with JDK v1.7.0_232
💙 spotbugs 3m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 2m 59s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 2m 2s the patch passed
💚 compile 0m 41s the patch passed with JDK v1.8.0_222
💚 javac 0m 41s the patch passed
💚 compile 0m 46s the patch passed with JDK v1.7.0_232
💚 javac 0m 46s the patch passed
💔 checkstyle 1m 48s hbase-server: The patch generated 3 new + 374 unchanged - 0 fixed = 377 total (was 374)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 3m 4s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 9s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 30s the patch passed with JDK v1.8.0_222
💚 javadoc 0m 41s the patch passed with JDK v1.7.0_232
💚 findbugs 3m 4s the patch passed
_ Other Tests _
💚 unit 119m 47s hbase-server in the patch passed.
💚 asflicense 0m 28s The patch does not generate ASF License warnings.
161m 25s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/artifact/out/Dockerfile
GITHUB PR #694
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f8eb9d19ec2c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-694/out/precommit/personality/provided.sh
git revision branch-1 / 3966d0f
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/testReport/
Max. process+thread count 4049 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-694/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants