Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 #683

Merged
merged 1 commit into from
Oct 7, 2019
Merged

HBASE-23110 Backport HBASE-23054 "Remove synchronization block from MetaTableMetrics and fix LossyCounting algorithm" to branch-1 #683

merged 1 commit into from
Oct 7, 2019

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Oct 3, 2019

No description provided.

@apurtell apurtell requested a review from xcangCRM October 3, 2019 00:50
@apurtell
Copy link
Contributor Author

apurtell commented Oct 3, 2019 

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.util.TestLossyCounting
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.881 s - in org.apache.hadoop.hbase.util.TestLossyCounting
[INFO] Running org.apache.hadoop.hbase.coprocessor.TestMetaTableMetrics
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.004 s - in org.apache.hadoop.hbase.coprocessor.TestMetaTableMetrics

@apurtell apurtell requested a review from Apache9 October 3, 2019 00:58
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 20s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
💚 mvninstall 8m 36s branch-1 passed
💚 compile 0m 40s branch-1 passed with JDK v1.8.0_222
💚 compile 0m 44s branch-1 passed with JDK v1.7.0_232
💚 checkstyle 1m 30s branch-1 passed
💚 shadedjars 2m 57s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 35s branch-1 passed with JDK v1.8.0_222
💚 javadoc 0m 41s branch-1 passed with JDK v1.7.0_232
💙 spotbugs 2m 48s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 2m 46s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 2m 0s the patch passed
💚 compile 0m 40s the patch passed with JDK v1.8.0_222
💚 javac 0m 40s the patch passed
💚 compile 0m 45s the patch passed with JDK v1.7.0_232
💚 javac 0m 45s the patch passed
💔 checkstyle 1m 29s hbase-server: The patch generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 47s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 0s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 32s the patch passed with JDK v1.8.0_222
💚 javadoc 0m 41s the patch passed with JDK v1.7.0_232
💔 findbugs 2m 51s hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
💔 unit 156m 34s hbase-server in the patch failed.
💚 asflicense 0m 38s The patch does not generate ASF License warnings.
197m 30s
Reason Tests
FindBugs module:hbase-server
Unread field:LossyCounting.java:[line 56]
Unread field:LossyCounting.java:[line 57]
Failed junit tests hadoop.hbase.regionserver.TestRegionServerHostname
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/Dockerfile
GITHUB PR #683
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux bfca61c45b83 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-683/out/precommit/personality/provided.sh
git revision branch-1 / 0ffbf9c
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/diff-checkstyle-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/new-findbugs-hbase-server.html
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/testReport/
Max. process+thread count 4113 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

apurtell commented Oct 4, 2019

The unit test failures are not related but let me fix the findbugs

@apurtell apurtell force-pushed the HBASE-23110-branch-1 branch from 8663d6d to df0baaa Compare October 5, 2019 00:16
@apurtell
Copy link
Contributor Author

apurtell commented Oct 5, 2019

Rebased with fixes for findbugs and checkstyle warnings

@apurtell apurtell force-pushed the HBASE-23110-branch-1 branch 2 times, most recently from 69f3b67 to d563b11 Compare October 5, 2019 00:19
@apurtell
HBASE-23110 Backport HBASE-23054 "Remove synchronization block from M…
d563b11 
…etaTableMetrics and fix LossyCounting algorithm" to branch-1

Additional fixes for reported findbugs and checkstyle warnings.
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 20s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-1 Compile Tests _
💚 mvninstall 8m 33s branch-1 passed
💚 compile 0m 42s branch-1 passed with JDK v1.8.0_222
💚 compile 0m 46s branch-1 passed with JDK v1.7.0_232
💚 checkstyle 1m 47s branch-1 passed
💚 shadedjars 3m 22s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 40s branch-1 passed with JDK v1.8.0_222
💚 javadoc 0m 47s branch-1 passed with JDK v1.7.0_232
💙 spotbugs 3m 17s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 3m 13s branch-1 passed
_ Patch Compile Tests _
💚 mvninstall 2m 25s the patch passed
💚 compile 0m 50s the patch passed with JDK v1.8.0_222
💚 javac 0m 50s the patch passed
💚 compile 0m 55s the patch passed with JDK v1.7.0_232
💚 javac 0m 55s the patch passed
💔 checkstyle 1m 49s hbase-server: The patch generated 1 new + 0 unchanged - 2 fixed = 1 total (was 2)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 3m 48s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 5m 51s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 javadoc 0m 32s the patch passed with JDK v1.8.0_222
💚 javadoc 0m 41s the patch passed with JDK v1.7.0_232
💚 findbugs 3m 7s the patch passed
_ Other Tests _
💔 unit 143m 20s hbase-server in the patch failed.
💚 asflicense 0m 30s The patch does not generate ASF License warnings.
189m 1s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/2/artifact/out/Dockerfile
GITHUB PR #683
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ff9a3dc98828 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-683/out/precommit/personality/provided.sh
git revision branch-1 / c63b2f4
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/2/testReport/
Max. process+thread count 4882 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-683/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell merged commit 6421112 into apache:branch-1 Oct 7, 2019
@apurtell apurtell deleted the HBASE-23110-branch-1 branch October 7, 2019 18:10
asfgit pushed a commit that referenced this pull request Oct 7, 2019
@apurtell
HBASE-23110 Backport HBASE-23054 "Remove synchronization block from M…
44a29d8 
…etaTableMetrics and fix LossyCounting algorithm" to branch-1 (#683)

Additional fixes for reported findbugs and checkstyle warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcangCRM xcangCRM Awaiting requested review from xcangCRM

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apurtell @Apache-HBase