Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23101 Backport HBASE-22380 to branch-1 #680

Closed
wants to merge 1 commit into from
Closed

HBASE-23101 Backport HBASE-22380 to branch-1 #680

wants to merge 1 commit into from

Conversation

wchevreuil
Copy link
Contributor

Right, had come with a branch-1 version of HBASE-22380. Compiled and ran some replication related UTs passing. Let's see what pre-commit says.

apurtell
apurtell approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@apurtell apurtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will apply if local tests check out

@apurtell apurtell closed this Oct 2, 2019
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 51s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💙 prototool 0m 1s prototool was not available.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-1 Compile Tests _
💙 mvndep 6m 27s Maven dependency ordering for branch
💚 mvninstall 3m 57s branch-1 passed
💚 compile 1m 36s branch-1 passed with JDK v1.8.0_222
💚 compile 1m 44s branch-1 passed with JDK v1.7.0_232
💚 checkstyle 5m 39s branch-1 passed
💚 shadedjars 2m 57s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 1m 3s branch-1 passed with JDK v1.8.0_222
💚 javadoc 1m 18s branch-1 passed with JDK v1.7.0_232
💙 spotbugs 2m 37s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 6m 5s branch-1 passed
_ Patch Compile Tests _
💙 mvndep 0m 14s Maven dependency ordering for patch
💚 mvninstall 1m 58s the patch passed
💚 compile 1m 24s the patch passed with JDK v1.8.0_222
💚 cc 1m 24s the patch passed
💚 javac 1m 24s the patch passed
💚 compile 1m 34s the patch passed with JDK v1.7.0_232
💚 cc 1m 34s the patch passed
💚 javac 1m 34s the patch passed
💔 checkstyle 0m 48s hbase-client: The patch generated 16 new + 463 unchanged - 0 fixed = 479 total (was 463)
💔 checkstyle 1m 49s hbase-server: The patch generated 5 new + 734 unchanged - 2 fixed = 739 total (was 736)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 45s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 4m 59s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
💚 hbaseprotoc 1m 54s the patch passed
💔 javadoc 0m 20s hbase-client-jdk1.8.0_222 with JDK v1.8.0_222 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
💔 javadoc 0m 24s hbase-client-jdk1.7.0_232 with JDK v1.7.0_232 generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
💚 findbugs 6m 50s the patch passed
_ Other Tests _
💚 unit 0m 30s hbase-protocol in the patch passed.
💚 unit 2m 44s hbase-client in the patch passed.
💔 unit 121m 11s hbase-server in the patch failed.
💚 asflicense 1m 11s The patch does not generate ASF License warnings.
190m 39s
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterOperationsForRegionReplicas
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/Dockerfile
GITHUB PR #680
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname Linux 8d81e7f7b703 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-680/out/precommit/personality/provided.sh
git revision branch-1 / dd9eadb
Default Java 1.7.0_232
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_222 /usr/lib/jvm/zulu-7-amd64:1.7.0_232
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/diff-checkstyle-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.8.0_222.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/diff-javadoc-javadoc-hbase-client-jdk1.7.0_232.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/testReport/
Max. process+thread count 4366 (vs. ulimit of 10000)
modules C: hbase-protocol hbase-client hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-680/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Oct 2, 2019
@wchevreuil @apurtell
HBASE-23101 Backport HBASE-22380 to branch-1
0ffbf9c 
Fixes #680

Signed-off-by: Andrew Purtell <[email protected]>
asfgit pushed a commit that referenced this pull request Oct 2, 2019
@wchevreuil @apurtell
HBASE-23101 Backport HBASE-22380 to branch-1
84f95fc 
Fixes #680

Signed-off-by: Andrew Purtell <[email protected]>

Conflicts:
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
	hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
asfgit pushed a commit that referenced this pull request Oct 2, 2019
@wchevreuil @apurtell
HBASE-23101 Backport HBASE-22380 to branch-1
f574982 
Fixes #680

Signed-off-by: Andrew Purtell <[email protected]>

Conflicts:
	hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@busbey busbey Awaiting requested review from busbey

@joshelser joshelser Awaiting requested review from joshelser

@petersomogyi petersomogyi Awaiting requested review from petersomogyi

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wchevreuil @Apache-HBase @apurtell