Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28983 Added static resources under hbase-rest project #6491

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

HBASE-28983 Added static resources under hbase-rest project #6491

wants to merge 4 commits into from

Conversation

PDavid
Copy link
Contributor

@PDavid PDavid commented Nov 22, 2024 •
edited
Loading

Added static resources under hbase-rest project to fix the problem that static resources (CSS, JS, images) were not loaded on REST web UI pages.

Basically copyed the hbase-thrift/src/main/resources/hbase-webapps/static folder under hbase-rest/src/main/resources/hbase-webapps.

This PR kind of clashes with #6490 so depending on which goes in first, the other has to be adjusted.

@PDavid
HBASE-28983 Added static resources under hbase-rest project
0884e6e 
to fix the problem that static resources (CSS, JS, images) were not loaded on REST web UI pages.
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@PDavid
HBASE-28983 Fixed blank whitespaces
5293c26 
Fixed lines that:
- ended in blanks.
- used a tab.

This was found by the CI build checks.
@PDavid
HBASE-28983 Removed unneeded image hbase_logo_med.gif
ebcddf2 
This is not referenced from anywhere in the project.
@PDavid
HBASE-28983 Use hbase_logo_small.png from hbase-server project
9df1e09 
Reason: to make sure that they are the same size (this under thrift was smaller).
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 54s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
9m 39s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6491/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6491
Optional Tests dupname asflicense javac codespell detsecrets spotless jshint
uname Linux 2d07257c98dc 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9df1e09
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6491/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 26s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 59s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 javadoc 0m 16s the patch passed
_ Other Tests _
+1 💚 unit 3m 53s hbase-rest in the patch passed.
11m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6491/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6491
Optional Tests javac javadoc unit
uname Linux fe0dadeae1db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9df1e09
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6491/3/testReport/
Max. process+thread count 1713 (vs. ulimit of 30000)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6491/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid PDavid marked this pull request as ready for review November 22, 2024 15:10
@Apache9 Apache9 requested a review from NihalJain November 25, 2024 07:49
@stoty
Copy link
Contributor

stoty commented Nov 27, 2024

Let's hold this until the JS library updetes are done.

@PDavid PDavid marked this pull request as draft November 27, 2024 09:32
@PDavid
Copy link
Contributor Author

PDavid commented Nov 27, 2024

Let's hold this until the JS library updetes are done.

Thanks, good idea. 👍

Changing this back to draft as after #6490 is merged, this has to be redone with the new Bootstrap version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NihalJain NihalJain Awaiting requested review from NihalJain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PDavid @Apache-HBase @stoty