Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-23046 Remove compatibility case from truncate command #638

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

petersomogyi
Copy link
Contributor

No description provided.

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a release note that the admin won't work when talking to a pre-1.0 cluster? I have a hard time believing admin in e.g. branch-2 worked with a pre-1.0 cluster before this change.

@petersomogyi
Copy link
Contributor Author

I don't think upgrade works from pre-1.0 to 2+ cluster. I can add a release note to the Jira if you think it's needed.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚 mvninstall 8m 1s master passed
💚 javadoc 0m 17s master passed
_ Patch Compile Tests _
💚 mvninstall 6m 23s the patch passed
💔 rubocop 0m 14s The patch generated 4 new + 436 unchanged - 14 fixed = 440 total (was 450)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 javadoc 0m 14s the patch passed
_ Other Tests _
💚 unit 7m 6s hbase-shell in the patch passed.
💚 asflicense 0m 14s The patch does not generate ASF License warnings.
24m 24s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/artifact/out/Dockerfile
GITHUB PR #638
Optional Tests dupname asflicense javac javadoc unit rubocop
uname Linux 23f37109836c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-638/out/precommit/personality/provided.sh
git revision master / 25bcc91
Default Java 1.8.0_181
rubocop https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/artifact/out/diff-patch-rubocop.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/testReport/
Max. process+thread count 2625 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 32s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 @author 0m 0s The patch does not contain any @author tags.
💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
💚 mvninstall 6m 31s master passed
💚 javadoc 0m 18s master passed
_ Patch Compile Tests _
💚 mvninstall 5m 56s the patch passed
💚 rubocop 0m 18s The patch generated 0 new + 419 unchanged - 31 fixed = 419 total (was 450)
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 javadoc 0m 15s the patch passed
_ Other Tests _
💚 unit 8m 6s hbase-shell in the patch passed.
💚 asflicense 0m 13s The patch does not generate ASF License warnings.
23m 16s
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/artifact/out/Dockerfile
GITHUB PR #638
Optional Tests dupname asflicense javac javadoc unit rubocop
uname Linux 760389f003dc 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-638/out/precommit/personality/provided.sh
git revision master / 25bcc91
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/testReport/
Max. process+thread count 2759 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-638/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) rubocop=0.74.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi petersomogyi merged commit 08b82c5 into apache:master Sep 19, 2019
asfgit pushed a commit that referenced this pull request Sep 19, 2019
@petersomogyi petersomogyi deleted the HBASE-23046 branch September 23, 2019 07:19
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
Author: Peter Somogyi
Reason: Bug
Ref: CDH-82052

Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit 08b82c5)
Change-Id: I9a748ea60a2e6e1b3bb17c52892909b694bab07e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants