HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to support non replica actions #6143

droudnitsky · 2024-08-07T16:59:16Z

There is an example of the change being used in PR #6144.

Since isActionComplete currently only has one caller that depends on the replica action check we can move the replica action check to the caller method instead of having the check be inside isActionComplete.

The case of AsyncRequestFutureImpl without result tracking/null results:
The function does not support a AsyncRequestFutureImpl with null results (neither before nor after my proposed changes). I don't currently see a way to reliably check for action completion from within AsyncRequestFutureImpl for the null results case (I don't know how common this case is in practice, but it is accommodated for across AsyncRequestFutureImpl, and I test that path with Table.batch(List<Row>, null)). My understanding of that code is that in the null results case one cannot readily tell whether a given action has completed from within AsyncRequestFutureImpl because:

In the case of action success we just decrement action counter when calling setResult.
In the case of action failure the failure is tracked in BatchErrors, but BatchErrors does not track the action index for the failed action, only the Row, so even if we wanted to check whether for a given action an error was added to BatchErrors, we couldn't because of the way that Row equality is currently implemented - we can have two different actions in a batch with the same rows that are considered Row equal (e.g two gets for the same rowkey, but with different column family + column qualifiers specified, are considered equal).

If my understanding of AsyncRequestFutureImpl is flawed and/or there is a reliable way to do this check with null results, I would greatly appreciate the feedback.

The only current existing caller of this method will never hit the null results case because it only checks replica gets which will always have non-null results, and the proposed additional use of this method in PR #6144 currently will also only call the method in the non-null results case, so my proposal here is to just not support the null results case and throw IllegalStateException if one does try to call isActionComplete without checking that results exist.

Apache-HBase · 2024-08-07T17:31:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 35s		branch-2 passed
+1 💚	compile	0m 21s		branch-2 passed
+1 💚	javadoc	0m 20s		branch-2 passed
+1 💚	shadedjars	4m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s		the patch passed
+1 💚	compile	0m 21s		the patch passed
+1 💚	javac	0m 21s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed
+1 💚	shadedjars	4m 54s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 12s		hbase-client in the patch passed.
		26m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux cca2a605d6c5 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `150fa2b`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/testReport/
Max. process+thread count	347 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-07T17:34:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 2s		branch-2 passed
+1 💚	compile	0m 52s		branch-2 passed
+1 💚	checkstyle	0m 20s		branch-2 passed
+1 💚	spotbugs	0m 55s		branch-2 passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	0m 51s		the patch passed
+1 💚	javac	0m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 19s	/results-checkstyle-hbase-client.txt	hbase-client: The patch generated 1 new + 11 unchanged - 1 fixed = 12 total (was 12)
+1 💚	spotbugs	1m 0s		the patch passed
+1 💚	hadoopcheck	15m 20s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
-1 ❌	spotless	0m 21s		patch has 23 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		28m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 2593638861a4 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `150fa2b`
Default Java	Eclipse Adoptium-11.0.23+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-07T17:35:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 14s		branch-2 passed
+1 💚	compile	0m 23s		branch-2 passed
+1 💚	javadoc	0m 20s		branch-2 passed
+1 💚	shadedjars	5m 57s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	0m 23s		the patch passed
+1 💚	javac	0m 23s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed
+1 💚	shadedjars	5m 52s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 15s		hbase-client in the patch passed.
		29m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 86c7ac934ac3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `150fa2b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/testReport/
Max. process+thread count	386 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-07T17:36:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 22s		branch-2 passed
+1 💚	compile	0m 21s		branch-2 passed
+1 💚	javadoc	0m 19s		branch-2 passed
+1 💚	shadedjars	6m 13s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 13s		the patch passed
+1 💚	compile	0m 20s		the patch passed
+1 💚	javac	0m 20s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed
+1 💚	shadedjars	6m 9s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 21s		hbase-client in the patch passed.
		30m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 0221582f8979 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `150fa2b`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/testReport/
Max. process+thread count	379 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…rt non replica actions

Apache-HBase · 2024-08-08T02:16:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	2m 27s		branch-2 passed
+1 💚	compile	0m 21s		branch-2 passed
+1 💚	javadoc	0m 18s		branch-2 passed
+1 💚	shadedjars	4m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s		the patch passed
+1 💚	compile	0m 20s		the patch passed
+1 💚	javac	0m 20s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed
+1 💚	shadedjars	4m 55s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 16s		hbase-client in the patch passed.
		26m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6b4cd5f1fbd2 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ec2a58`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/testReport/
Max. process+thread count	345 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-08T02:19:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 0s		branch-2 passed
+1 💚	compile	0m 21s		branch-2 passed
+1 💚	javadoc	0m 18s		branch-2 passed
+1 💚	shadedjars	5m 34s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s		the patch passed
+1 💚	compile	0m 22s		the patch passed
+1 💚	javac	0m 22s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed
+1 💚	shadedjars	5m 55s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 42s		hbase-client in the patch passed.
		29m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 74e760fbd0b4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ec2a58`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/testReport/
Max. process+thread count	369 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-08T02:21:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 19s		branch-2 passed
+1 💚	compile	0m 21s		branch-2 passed
+1 💚	javadoc	0m 19s		branch-2 passed
+1 💚	shadedjars	6m 12s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	0m 22s		the patch passed
+1 💚	javac	0m 22s		the patch passed
+1 💚	javadoc	0m 18s		the patch passed
+1 💚	shadedjars	6m 8s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	8m 25s		hbase-client in the patch passed.
		30m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 522978b1fec1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ec2a58`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/testReport/
Max. process+thread count	390 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-08T02:22:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 33s		branch-2 passed
+1 💚	compile	0m 54s		branch-2 passed
+1 💚	checkstyle	0m 23s		branch-2 passed
+1 💚	spotbugs	1m 5s		branch-2 passed
+1 💚	spotless	0m 55s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 44s		the patch passed
+1 💚	compile	1m 4s		the patch passed
+1 💚	javac	1m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 25s		hbase-client: The patch generated 0 new + 11 unchanged - 1 fixed = 11 total (was 12)
+1 💚	spotbugs	1m 10s		the patch passed
+1 💚	hadoopcheck	15m 44s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		31m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6143
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux d3896bc46500 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0ec2a58`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6143/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to suppo…

0ec2a58

…rt non replica actions

droudnitsky force-pushed the branch-2-HBASE-27781-assert branch from 150fa2b to 0ec2a58 Compare August 8, 2024 01:48

droudnitsky mentioned this pull request Aug 8, 2024

HBASE-27781 Fix case of action counter assertion error in handling of batch operation timeout exceeded #6144

Open

droudnitsky marked this pull request as draft August 14, 2024 16:09

droudnitsky closed this Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to support non replica actions #6143

HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to support non replica actions #6143

droudnitsky commented Aug 7, 2024 •

edited

Loading

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to support non replica actions #6143

HBASE-28771 Refactor AsyncRequestFutureImpl.isActionComplete to support non replica actions #6143

Conversation

droudnitsky commented Aug 7, 2024 • edited Loading

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 7, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

Apache-HBase commented Aug 8, 2024

droudnitsky commented Aug 7, 2024 •

edited

Loading