Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28767 Simplify backup bulk-loading code #6134

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

DieterDP-ng
Copy link
Contributor

No functional changes.

Currently split into 2 commits as to help the reviewer with seeing what was changed. This can be squashed when merging.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than it was. thank you @DieterDP-ng

public static List<Delete> createDeleteForOrigBulkLoad(List<TableName> lst) {
// Unused???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we act on this comment now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill deal with it in HBASE-29003.

No functional changes.

Introduces the BulkLoad class as data container for the tracking
of which files were bulk loaded (for backup purposes).
This class could be a record class, but that would make backporting
less straightforward.
@DieterDP-ng
Copy link
Contributor Author

Apologies for letting this gather dust. Review comments have been addressed.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@DieterDP-ng
Copy link
Contributor Author

💔 -1 overall
Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 4s Docker failed to build run-specific yetus/hbase:tp-18400}.
Subsystem Report/Notes
GITHUB PR #6134
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/2/console
versions git=2.17.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This looks a failure unrelated to the PR to me. Let me know if this is not the case.

Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my nits. This is looking good by me. I've initiated another PR build since the last one had some infra-level failure.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 5s master passed
+1 💚 compile 0m 29s master passed
+1 💚 checkstyle 0m 10s master passed
+1 💚 spotbugs 0m 32s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 0m 30s the patch passed
+1 💚 javac 0m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 7s /buildtool-patch-checkstyle-hbase-backup.txt The patch fails to run checkstyle in hbase-backup
+1 💚 spotbugs 0m 37s the patch passed
+1 💚 hadoopcheck 10m 59s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
28m 15s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6134
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 8c011f88d156 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5932ae3
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-backup U: hbase-backup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 20s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 13s master passed
+1 💚 compile 0m 20s master passed
+1 💚 javadoc 0m 15s master passed
+1 💚 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 39s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 15m 35s hbase-backup in the patch passed.
33m 27s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6134
Optional Tests javac javadoc unit compile shadedjars
uname Linux f67eedb73dd9 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5932ae3
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/3/testReport/
Max. process+thread count 2972 (vs. ulimit of 30000)
modules C: hbase-backup U: hbase-backup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6134/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 5f312dd into apache:master Dec 13, 2024
1 check passed
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Dec 13, 2024
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Dec 13, 2024
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Dec 13, 2024
ndimiduk pushed a commit that referenced this pull request Dec 13, 2024
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Dec 16, 2024
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Dec 16, 2024
ndimiduk pushed a commit that referenced this pull request Dec 17, 2024
ndimiduk pushed a commit that referenced this pull request Dec 17, 2024
gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants