HBASE-28675 Change releaseTarget to 17 and also remove unused profile… #6037

Apache9 · 2024-07-01T09:59:22Z

… for older jdk versions in pom

Apache-HBase · 2024-07-01T10:57:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s		master passed
+1 💚	compile	7m 10s		master passed
+1 💚	checkstyle	1m 7s		master passed
+1 💚	spotbugs	7m 6s		master passed
+1 💚	spotless	0m 41s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s		the patch passed
+1 💚	compile	7m 19s		the patch passed
-0 ⚠️	javac	7m 19s	/results-compile-javac-root.txt	root generated 33 new + 1174 unchanged - 5 fixed = 1207 total (was 1179)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
-1 ❌	spotbugs	7m 6s	/new-spotbugs-root.html	root generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 💚	hadoopcheck	5m 13s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		51m 43s

Reason	Tests
SpotBugs	module:root
	org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.deleteFileOnClose(File) may fail to close stream At BucketCache.java:stream At BucketCache.java:[line 1462]
	Call to method of static java.text.DateFormat in org.apache.hadoop.hbase.regionserver.ServerNonceManager$OperationContext.toString() At ServerNonceManager.java:java.text.DateFormat in org.apache.hadoop.hbase.regionserver.ServerNonceManager$OperationContext.toString() At ServerNonceManager.java:[line 68]
	org.apache.hadoop.hbase.regionserver.throttle.StoreHotnessProtector.start(Map) concatenates strings using + in a loop At StoreHotnessProtector.java:in a loop At StoreHotnessProtector.java:[line 153]

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux b98ce2fcef2a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be322c7`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: hbase-common . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-01T15:18:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 33s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	2m 7s		master passed
+1 💚	shadedjars	5m 46s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	2m 8s		the patch passed
-0 ⚠️	javac	2m 8s	/results-compile-javac-root.txt	root generated 75 new + 0 unchanged - 0 fixed = 75 total (was 0)
+1 💚	javadoc	2m 8s		the patch passed
+1 💚	shadedjars	5m 40s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	277m 34s		root in the patch passed.
		312m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f5603a071e8c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be322c7`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/1/testReport/
Max. process+thread count	8653 (vs. ulimit of 30000)
modules	C: hbase-common . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-07-01T15:53:51Z

Ah, good, tests passed.

Let me cleanup the spotbugs and error prone issues if possible.

Apache9 · 2024-07-01T16:08:34Z

Most new javac warnings are about deprecated java APIs like SecurityManager.

Apache-HBase · 2024-07-01T17:51:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 40s		master passed
+1 💚	compile	11m 33s		master passed
+1 💚	checkstyle	1m 38s		master passed
+1 💚	spotbugs	15m 39s		master passed
+1 💚	spotless	1m 3s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 13s		the patch passed
+1 💚	compile	12m 3s		the patch passed
-0 ⚠️	javac	12m 3s	/results-compile-javac-root.txt	root generated 31 new + 1174 unchanged - 5 fixed = 1205 total (was 1179)
+1 💚	blanks	0m 1s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 44s	/results-checkstyle-root.txt	root: The patch generated 1 new + 19 unchanged - 2 fixed = 20 total (was 21)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	17m 0s		the patch passed
+1 💚	hadoopcheck	7m 26s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	1m 11s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 19s		The patch does not generate ASF License warnings.
		90m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname	Linux 5198750bf889 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `489b5d7`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	187 (vs. ulimit of 30000)
modules	C: hbase-common hbase-hadoop-compat hbase-client hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-01T21:29:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	3m 0s		master passed
+1 💚	shadedjars	5m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	2m 7s		the patch passed
-0 ⚠️	javac	2m 7s	/results-compile-javac-root.txt	root generated 74 new + 0 unchanged - 0 fixed = 74 total (was 0)
+1 💚	javadoc	2m 57s		the patch passed
+1 💚	shadedjars	5m 42s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	273m 31s		root in the patch passed.
		308m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 29088c3fb726 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `489b5d7`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/2/testReport/
Max. process+thread count	8754 (vs. ulimit of 30000)
modules	C: hbase-common hbase-hadoop-compat hbase-client hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-02T05:35:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s		master passed
+1 💚	compile	7m 22s		master passed
+1 💚	checkstyle	1m 12s		master passed
+1 💚	spotbugs	9m 22s		master passed
+1 💚	spotless	0m 40s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s		the patch passed
+1 💚	compile	7m 16s		the patch passed
-0 ⚠️	javac	7m 16s	/results-compile-javac-root.txt	root generated 31 new + 1174 unchanged - 5 fixed = 1205 total (was 1179)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 9s		root: The patch generated 0 new + 19 unchanged - 2 fixed = 19 total (was 21)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	10m 30s		the patch passed
+1 💚	hadoopcheck	5m 9s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 40s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		60m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname	Linux ef80c3295788 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f2ddc1`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	192 (vs. ulimit of 30000)
modules	C: hbase-common hbase-hadoop-compat hbase-client hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-02T09:46:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 21s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s		master passed
+1 💚	compile	2m 6s		master passed
+1 💚	javadoc	2m 59s		master passed
+1 💚	shadedjars	5m 45s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	2m 5s		the patch passed
-0 ⚠️	javac	2m 5s	/results-compile-javac-root.txt	root generated 74 new + 0 unchanged - 0 fixed = 74 total (was 0)
+1 💚	javadoc	2m 57s		the patch passed
+1 💚	shadedjars	5m 39s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	274m 0s		root in the patch passed.
		311m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6037
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 3d6caf43e85b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8f2ddc1`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/3/testReport/
Max. process+thread count	8872 (vs. ulimit of 30000)
modules	C: hbase-common hbase-hadoop-compat hbase-client hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6037/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-07-02T09:57:26Z

@ndimiduk This is the PR for changing release target to 17. PTAL.

Thanks.

ndimiduk · 2024-07-02T18:22:34Z

hbase-common/src/main/java/org/apache/hadoop/hbase/io/compress/Compression.java

@@ -554,6 +554,7 @@ private static CompressionCodec buildCodec(final Configuration conf, final Algor
        throw new RuntimeException("No codec configured for " + algo.confKey);
      }
      Class<?> codecClass = getClassLoaderForCodec().loadClass(codecClassName);
+      // The class is from hadoop so we use hadoop's ReflectionUtils to create it


… for older jdk versions in pom (#6037) Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 0a1f1c4)

HBASE-28675 Change releaseTarget to 17 and also remove unused profile…

be322c7

… for older jdk versions in pom

fix spotbugs

489b5d7

Apache9 requested a review from ndimiduk July 1, 2024 16:07

fix checkstyle

8f2ddc1

ndimiduk approved these changes Jul 2, 2024

View reviewed changes

Apache9 merged commit 0a1f1c4 into apache:master Jul 3, 2024
1 check passed

Apache9 added a commit that referenced this pull request Jul 3, 2024

HBASE-28675 Change releaseTarget to 17 and also remove unused profile…

6fbe1cd

… for older jdk versions in pom (#6037) Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 0a1f1c4)

Apache9 mentioned this pull request Jul 10, 2024

HBASE-28707 Backport the code changes in HBASE-28675 to branch-2.x #6043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28675 Change releaseTarget to 17 and also remove unused profile… #6037

HBASE-28675 Change releaseTarget to 17 and also remove unused profile… #6037

Apache9 commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache9 commented Jul 1, 2024

Apache9 commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 2, 2024

Apache-HBase commented Jul 2, 2024

Apache9 commented Jul 2, 2024

ndimiduk Jul 2, 2024

HBASE-28675 Change releaseTarget to 17 and also remove unused profile… #6037

HBASE-28675 Change releaseTarget to 17 and also remove unused profile… #6037

Conversation

Apache9 commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache9 commented Jul 1, 2024

Apache9 commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 1, 2024

Apache-HBase commented Jul 2, 2024

Apache-HBase commented Jul 2, 2024

Apache9 commented Jul 2, 2024

ndimiduk Jul 2, 2024

Choose a reason for hiding this comment