Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28679 Upgrade yetus to a newer version #6012

Merged
merged 1 commit into from
Jun 22, 2024
Merged

HBASE-28679 Upgrade yetus to a newer version #6012

merged 1 commit into from
Jun 22, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jun 21, 2024

No description provided.

@Apache9 Apache9 requested a review from ndimiduk June 21, 2024 07:22
@Apache9 Apache9 self-assigned this Jun 21, 2024
@Apache9
Copy link
Contributor Author

Apache9 commented Jun 21, 2024

For pre commit, see

#6005

For Nightly build, see

https://ci-hbase.apache.org/job/HBase%20Nightly/job/HBASE-28679/3/

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console in case of problems.

3 similar comments
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console in case of problems.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console in case of problems.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console in case of problems.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
_ Other Tests _
1m 42s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #6012
Optional Tests
uname Linux 0da7b3a38c49 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 99f296a
Max. process+thread count 33 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
2m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6012
Optional Tests
uname Linux 3cc43f19be2a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 99f296a
Max. process+thread count 43 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --blanks-eol-ignore-list --blanks-tabs-ignore-list
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 0s No new issues.
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
3m 49s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6012
Optional Tests dupname asflicense codespell detsecrets hadolint shellcheck shelldocs spotless
uname Linux 92e7b853bf9a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 99f296a
Max. process+thread count 44 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console
versions git=2.34.1 maven=3.8.6 hadolint=2.10.0 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 51s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-list --blanks-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
4m 52s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6012
Optional Tests
uname Linux 61f65f92b495 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 99f296a
Max. process+thread count 36 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6012/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk
ndimiduk approved these changes Jun 21, 2024
View reviewed changes
dev-support/Jenkinsfile
// output from surefire; sadly the archive function in yetus only works on file names.
ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump'
// These tests currently have known failures. Once they burn down to 0, remove from here so that new problems will cause a failure.
TESTS_FILTER = 'cc,checkstyle,javac,javadoc,pylint,shellcheck,whitespace,perlcritic,ruby-lint,rubocop,mvnsite'
TESTS_FILTER = 'checkstyle,javac,javadoc,pylint,shellcheck,shelldocs,blanks,perlcritic,ruby-lint,rubocop'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have C code in the repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have some c code in hbase-example...

dev-support/Jenkinsfile_GitHub
@@ -102,11 +104,11 @@ pipeline {
checkout scm
}
dir("${YETUSDIR}") {
checkout([
$class : 'GitSCM',
branches : [[name: "${YETUS_VERSION}"]],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, this previous behavior was so that we could test with upstream yetus feature branch if need be. Maybe unrealistic...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a special option for nightly job, for using the newest yetus code.

I think later we could introduce the same logic for pre commit.

dev-support/Jenkinsfile_GitHub
allOf {
// this will return true if the pipeline is building a change request, such as a GitHub pull request.
changeRequest()
expression { env.CHANGE_TARGET in ['master', 'branch-3'] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be when in [master, branch-3, branch-2] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change this part later in HBASE-28678. We still have some problem for jdk17 builds, for example, we do not unstash the result later so on the final jira report we missed the jdk 17 line...

@Apache9 Apache9 merged commit 17ce7c3 into master Jun 22, 2024
1 check passed
Apache9 added a commit that referenced this pull request Jun 22, 2024
@Apache9
HBASE-28679 Upgrade yetus to a newer version (#6012)
014fc51 
Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit 17ce7c3)
Apache9 added a commit that referenced this pull request Jun 22, 2024
@Apache9
HBASE-28679 Upgrade yetus to a newer version (#6012)
5b72290 
Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit 17ce7c3)
@Apache9 Apache9 deleted the HBASE-28679 branch June 22, 2024 02:38
Apache9 added a commit that referenced this pull request Jun 22, 2024
@Apache9
HBASE-28679 Upgrade yetus to a newer version (#6012)
6f93e93 
Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit 17ce7c3)
Apache9 added a commit that referenced this pull request Jun 22, 2024
@Apache9
HBASE-28679 Upgrade yetus to a newer version (#6012)
265dcb4 
Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit 17ce7c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @ndimiduk