-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars #5918
Merged
ndimiduk
merged 1 commit into
apache:master
from
ndimiduk:28605-ban-import-hadoop-thirdparty
May 22, 2024
Merged
HBASE-28605 Add ErrorProne ban on Hadoop shaded thirdparty jars #5918
ndimiduk
merged 1 commit into
apache:master
from
ndimiduk:28605-ban-import-hadoop-thirdparty
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbeaudreault
approved these changes
May 17, 2024
Apache9
approved these changes
May 17, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ```
ndimiduk
force-pushed
the
28605-ban-import-hadoop-thirdparty
branch
from
May 21, 2024 08:10
ba6ab0f
to
6f6dce9
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 22, 2024
…he#5918) This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 22, 2024
…he#5918) This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 22, 2024
…he#5918) This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
May 22, 2024
…he#5918) This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 23, 2024
This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 23, 2024
This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 23, 2024
This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 23, 2024
This change results in this error on master at `3a3dd66e21`. ``` [WARNING] Rule 2: de.skuzzle.enforcer.restrictimports.rule.RestrictImports failed with message: Banned imports detected: Reason: Use shaded version in hbase-thirdparty in file: org/apache/hadoop/hbase/backup/TestBackupDelete.java org.apache.hadoop.thirdparty.com.google.common.collect.Sets (Line: 34, Matched by: org.apache.hadoop.thirdparty.**) ``` Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change results in this error on master at
3a3dd66e21
.