Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2.6 #5916

Merged
merged 2 commits into from
May 18, 2024
Merged

Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2.6 #5916

merged 2 commits into from
May 18, 2024

Conversation

ndimiduk
Copy link
Member

The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in that root dir).

The incremental backup set can only shrink when backups are deleted. However, the implementation was incorrect, causing this set to never be able to shrink.

Reviewed-by: Ray Mattingly [email protected]

@ndimiduk ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label May 17, 2024
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
@Apache-HBase

This comment was marked as outdated.

Sign in to view
DieterDP-ng and others added 2 commits May 17, 2024 18:40
@DieterDP-ng @ndimiduk
HBASE-28568 Incremental backup set does not correctly shrink (apache#…
bcc4f78 
…5876)

The incremental backup set is the set of tables included when
an incremental backup is created, it is managed per backup
root dir and contains all tables that are present in at least
one backup (in that root dir).

The incremental backup set can only shrink when backups are
deleted. However, the implementation was incorrect, causing this
set to never be able to shrink.

Reviewed-by: Ray Mattingly <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
@ndimiduk
HBASE-28568 Incremental backup set does not correctly shrink (addendu…
b8f6099 
…m) (apache#5917)

Import the correct shaded Guava and run spotless:apply.

Signed-off-by: Duo Zhang <[email protected]>
@ndimiduk ndimiduk force-pushed the 28568-branch-2.6 branch from 5598fe4 to b8f6099 Compare May 17, 2024 16:45
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 2m 31s branch-2.6 passed
+1 💚 compile 0m 17s branch-2.6 passed
+1 💚 shadedjars 4m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s branch-2.6 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 21s the patch passed
+1 💚 compile 0m 17s the patch passed
+1 💚 javac 0m 17s the patch passed
+1 💚 shadedjars 4m 45s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 11m 34s hbase-backup in the patch passed.
28m 32s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5916
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5f4ab4843c64 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 0ac43d4
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/testReport/
Max. process+thread count 3457 (vs. ulimit of 30000)
modules C: hbase-backup U: hbase-backup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 3m 6s branch-2.6 passed
+1 💚 compile 0m 16s branch-2.6 passed
+1 💚 shadedjars 5m 46s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s branch-2.6 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 shadedjars 6m 18s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 15s hbase-backup generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 unit 11m 56s hbase-backup in the patch passed.
32m 35s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5916
Optional Tests javac javadoc unit shadedjars compile
uname Linux 11dc5bce35bc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 0ac43d4
Default Java Eclipse Adoptium-11.0.17+8
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-backup.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/testReport/
Max. process+thread count 3797 (vs. ulimit of 30000)
modules C: hbase-backup U: hbase-backup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.6 Compile Tests _
+1 💚 mvninstall 5m 2s branch-2.6 passed
+1 💚 compile 0m 44s branch-2.6 passed
+1 💚 checkstyle 0m 13s branch-2.6 passed
+1 💚 spotless 1m 9s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 52s branch-2.6 passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 javac 0m 38s hbase-backup generated 0 new + 104 unchanged - 2 fixed = 104 total (was 106)
+1 💚 checkstyle 0m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 15m 0s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.
+1 💚 spotless 1m 15s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 4s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
33m 36s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5916
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 34ee7767cff4 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.6 / 0ac43d4
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-backup U: hbase-backup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5916/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit ba12a6b into apache:branch-2.6 May 18, 2024
1 check passed
@ndimiduk ndimiduk deleted the 28568-branch-2.6 branch May 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndimiduk @Apache-HBase @DieterDP-ng