Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28572 Remove deprecated methods in thrift module #5882

Merged
merged 1 commit into from
May 17, 2024
Merged

HBASE-28572 Remove deprecated methods in thrift module #5882

merged 1 commit into from
May 17, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented May 8, 2024

No description provided.

@Apache9 Apache9 self-assigned this May 8, 2024
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 21s master passed
+1 💚 compile 0m 50s master passed
+1 💚 shadedjars 5m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 49s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 46s the patch passed
+1 💚 compile 0m 45s the patch passed
+1 💚 javac 0m 45s the patch passed
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 47s the patch passed
_ Other Tests _
+1 💚 unit 7m 49s hbase-thrift in the patch passed.
+1 💚 unit 1m 52s hbase-examples in the patch passed.
32m 36s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5882
Optional Tests javac javadoc unit shadedjars compile
uname Linux 060227abee23 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23fa363
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count 1321 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 15s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 3m 15s master passed
+1 💚 compile 0m 57s master passed
+1 💚 shadedjars 7m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 50s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 38s the patch passed
+1 💚 compile 0m 40s the patch passed
+1 💚 javac 0m 40s the patch passed
+1 💚 shadedjars 5m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s the patch passed
_ Other Tests _
+1 💚 unit 6m 52s hbase-thrift in the patch passed.
+1 💚 unit 2m 0s hbase-examples in the patch passed.
32m 40s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5882
Optional Tests javac javadoc unit shadedjars compile
uname Linux ac32f66bf879 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23fa363
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count 1384 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 4m 22s master passed
+1 💚 compile 1m 28s master passed
+1 💚 checkstyle 0m 42s master passed
+1 💚 spotless 0m 52s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 17s the patch passed
+1 💚 compile 1m 9s the patch passed
+1 💚 javac 1m 9s the patch passed
+1 💚 checkstyle 0m 41s the patch passed
-0 ⚠️ pylint 0m 33s The patch generated 149 new + 945 unchanged - 35 fixed = 1094 total (was 980)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 6m 6s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 1m 2s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 27s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
34m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5882
Optional Tests dupname asflicense javac spotless pylint shellcheck shelldocs spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 42408d858cbc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23fa363
Default Java Eclipse Adoptium-11.0.17+8
pylint https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-general-check/output/diff-patch-pylint.txt
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3 pylint=2.15.5
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 31s master passed
+1 💚 compile 0m 54s master passed
+1 💚 shadedjars 6m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 26s the patch passed
+1 💚 compile 0m 55s the patch passed
+1 💚 javac 0m 55s the patch passed
+1 💚 shadedjars 7m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 57s the patch passed
_ Other Tests _
+1 💚 unit 6m 44s hbase-thrift in the patch passed.
+1 💚 unit 2m 9s hbase-examples in the patch passed.
35m 40s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5882
Optional Tests javac javadoc unit shadedjars compile
uname Linux 87b838d0823b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 23fa363
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/testReport/
Max. process+thread count 1658 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5882/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ddupg
ddupg approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@ddupg ddupg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 merged commit 0db26ec into apache:master May 17, 2024
1 check passed
Apache9 added a commit that referenced this pull request May 17, 2024
@Apache9
HBASE-28572 Remove deprecated methods in thrift module (#5882)
0fa92e6 
Signed-off-by: Xin Sun <[email protected]>
(cherry picked from commit 0db26ec)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@Apache9 @vinayakphegde
HBASE-28572 Remove deprecated methods in thrift module (apache#5882)
064bf6f 
Signed-off-by: Xin Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddupg ddupg ddupg approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @ddupg