Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28558 Fix constructors for sub classes of Connection #5861

Merged
merged 1 commit into from
May 1, 2024
Merged

HBASE-28558 Fix constructors for sub classes of Connection #5861

merged 1 commit into from
May 1, 2024

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 29, 2024

No description provided.

@Apache9 Apache9 self-assigned this Apr 29, 2024
@Apache9 Apache9 mentioned this pull request Apr 29, 2024
Closed
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 57s master passed
+1 💚 compile 1m 24s master passed
+1 💚 checkstyle 0m 33s master passed
+1 💚 spotless 0m 57s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 26s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 1m 37s the patch passed
-0 ⚠️ javac 0m 43s hbase-mapreduce generated 2 new + 197 unchanged - 2 fixed = 199 total (was 199)
+1 💚 checkstyle 0m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 6m 31s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 53s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 52s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
32m 37s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5861
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 03527c4b484e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4230c42
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-client hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 38s master passed
+1 💚 compile 0m 38s master passed
+1 💚 shadedjars 5m 11s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 30s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 javac 0m 38s the patch passed
+1 💚 shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 30s the patch passed
_ Other Tests _
+1 💚 unit 1m 29s hbase-client in the patch passed.
+1 💚 unit 14m 47s hbase-mapreduce in the patch passed.
36m 47s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5861
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3f4bee2155e0 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4230c42
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count 2845 (vs. ulimit of 30000)
modules C: hbase-client hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 55s master passed
+1 💚 compile 0m 41s master passed
+1 💚 shadedjars 5m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 34s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 49s the patch passed
+1 💚 compile 0m 42s the patch passed
+1 💚 javac 0m 42s the patch passed
+1 💚 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 33s the patch passed
_ Other Tests _
+1 💚 unit 1m 36s hbase-client in the patch passed.
+1 💚 unit 17m 32s hbase-mapreduce in the patch passed.
40m 21s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5861
Optional Tests javac javadoc unit shadedjars compile
uname Linux fc561ff8b7bd 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4230c42
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count 3252 (vs. ulimit of 30000)
modules C: hbase-client hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 34s master passed
+1 💚 compile 0m 46s master passed
+1 💚 shadedjars 6m 11s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 shadedjars 6m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 32s the patch passed
_ Other Tests _
+1 💚 unit 1m 42s hbase-client in the patch passed.
+1 💚 unit 15m 3s hbase-mapreduce in the patch passed.
41m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5861
Optional Tests javac javadoc unit shadedjars compile
uname Linux f5cacce8adf7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4230c42
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/testReport/
Max. process+thread count 2927 (vs. ulimit of 30000)
modules C: hbase-client hbase-mapreduce U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5861/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

infraio
infraio approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@infraio infraio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

GeorryHuang
GeorryHuang approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@GeorryHuang GeorryHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Apache9 Apache9 merged commit e9ced39 into apache:master May 1, 2024
1 check passed
Apache9 added a commit that referenced this pull request May 1, 2024
@Apache9
HBASE-28558 Fix constructors for sub classes of Connection (#5861)
72b5c8f 
Signed-off-by: Guanghao Zhang <[email protected]>
Signed-off-by: GeorryHuang <[email protected]>
(cherry picked from commit e9ced39)
Apache9 added a commit that referenced this pull request May 1, 2024
@Apache9
HBASE-28558 Fix constructors for sub classes of Connection (#5861)
951f335 
Signed-off-by: Guanghao Zhang <[email protected]>
Signed-off-by: GeorryHuang <[email protected]>
(cherry picked from commit e9ced39)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024
@Apache9 @vinayakphegde
HBASE-28558 Fix constructors for sub classes of Connection (apache#5861)
721fe2b 
Signed-off-by: Guanghao Zhang <[email protected]>
Signed-off-by: GeorryHuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorryHuang GeorryHuang GeorryHuang approved these changes

@infraio infraio infraio approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Apache9 @Apache-HBase @infraio @GeorryHuang