HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5851

ksravista · 2024-04-24T19:28:48Z

OutputCommitter needs to be casted to PathOutputCommitter instead of FileOutputCommitter to allow S3 Magic committer as output committer. PathOutputCommitter is only available starting from Hadoop 3 so this change isn't backwards compatible with HBase using Hadoop 2.

As similar change will be applied to branch-2, which will be compatible with Hadoop 2 as well.

ksravista · 2024-04-24T19:36:09Z

@ndimiduk @bbeaudreault @rmdmattingly

rmdmattingly

Looks good to me. The branch-2 PR will probably be more contentious 😄

Apache-HBase · 2024-04-24T19:58:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 15s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	checkstyle	0m 11s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	checkstyle	0m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 35s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		23m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 1ea4f588d4d6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c6e776`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-24T20:06:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
-1 ❌	mvninstall	1m 5s	root in master failed.
-1 ❌	compile	0m 10s	hbase-mapreduce in master failed.
+1 💚	shadedjars	5m 41s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 7s	hbase-mapreduce in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 37s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 12s	hbase-mapreduce generated 17 new + 0 unchanged - 0 fixed = 17 total (was 0)
		_ Other Tests _
+1 💚	unit	14m 8s	hbase-mapreduce in the patch passed.
		31m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7f8d9732f184 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c6e776`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-mapreduce.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-mapreduce.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/testReport/
Max. process+thread count	2880 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-24T20:10:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	5m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	15m 11s	hbase-mapreduce in the patch passed.
		34m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fca97874357f 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c6e776`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/testReport/
Max. process+thread count	3279 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-24T20:31:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 51s	master passed
+1 💚	compile	0m 33s	master passed
+1 💚	shadedjars	8m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	8m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	24m 44s	hbase-mapreduce in the patch passed.
		55m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4bcfae5ada4d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `6c6e776`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/testReport/
Max. process+thread count	2829 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…tter

Apache-HBase · 2024-04-26T15:17:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	checkstyle	0m 16s	master passed
+1 💚	spotless	0m 53s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	checkstyle	0m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 43s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		26m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 1b7989cb99b4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52e0a8c`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-26T15:24:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	14m 27s	hbase-mapreduce in the patch passed.
		33m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3a1c26753c75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52e0a8c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/testReport/
Max. process+thread count	2900 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-26T15:25:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 6s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	14m 10s	hbase-mapreduce in the patch passed.
		34m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 44688eea1334 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52e0a8c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/testReport/
Max. process+thread count	2932 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-26T15:30:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	0m 24s	the patch passed
+1 💚	javac	0m 24s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	15m 44s	hbase-mapreduce in the patch passed.
		39m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5851
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 09029b965f7d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `52e0a8c`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/testReport/
Max. process+thread count	2979 (vs. ulimit of 30000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5851/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…tter (#5851) Co-authored-by: Sravi Kommineni <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Ray Mattingly <[email protected]> (cherry picked from commit 917f2f1)

Apache9 · 2024-05-06T08:48:00Z

@ksravista Do you have a jira account?

If not, please go to https://selfserve.apache.org/jira-account.html to register one so I can assign HBASE-28459 to you.

ksravista · 2024-05-07T13:07:31Z

Yes, my username is ksravista

…tter (apache#5851) Co-authored-by: Sravi Kommineni <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Ray Mattingly <[email protected]>

rmdmattingly approved these changes Apr 24, 2024

View reviewed changes

Apache9 approved these changes Apr 26, 2024

View reviewed changes

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic commi…

bca8be1

…tter

ksravista force-pushed the HBASE-28459 branch from f6dc46c to bca8be1 Compare April 26, 2024 14:47

ksravista mentioned this pull request Apr 26, 2024

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5858

Merged

Apache9 merged commit 917f2f1 into apache:master May 6, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5851

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5851

ksravista commented Apr 24, 2024

ksravista commented Apr 24, 2024

rmdmattingly left a comment

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache9 commented May 6, 2024

ksravista commented May 7, 2024

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5851

HBASE-28459 HFileOutputFormat2 ClassCastException with s3 magic committer #5851

Conversation

ksravista commented Apr 24, 2024

ksravista commented Apr 24, 2024

rmdmattingly left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 24, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache-HBase commented Apr 26, 2024

Apache9 commented May 6, 2024

ksravista commented May 7, 2024