Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure #5816

Merged
merged 8 commits into from
May 31, 2024
Prev Previous commit
Next Next commit
HBASE-28420 spotless apply
ukumawat committed May 30, 2024
commit ad84ebc0c1151e0c028388a588067dd8a5fbf14f
Original file line number Diff line number Diff line change
@@ -65,15 +65,15 @@
* <p>
* If sending the operation to remote RS failed, dispatcher will call remoteCallFailed() to handle
* this which calls remoteOperationDone with the exception. If the targetServer crashed but this
* procedure has no response or if we receive failed response, then dispatcher will call remoteOperationFailed() which also calls
* remoteOperationDone with the exception. If the operation is successful, then
* remoteOperationCompleted will be called and actually calls the remoteOperationDone without
* exception. In remoteOperationDone, we'll check if the procedure is already get wake up by others.
* Then developer could implement complete() based on their own purpose. But basic logic is that if
* operation succeed, set succ to true and do the clean work. If operation failed and require to
* resend it to the same server, leave the succ as false. If operation failed and require to resend
* it to another server, set succ to true and upper layer should be able to find out this operation
* not work and send a operation to another server.
* procedure has no response or if we receive failed response, then dispatcher will call
* remoteOperationFailed() which also calls remoteOperationDone with the exception. If the operation
* is successful, then remoteOperationCompleted will be called and actually calls the
* remoteOperationDone without exception. In remoteOperationDone, we'll check if the procedure is
* already get wake up by others. Then developer could implement complete() based on their own
* purpose. But basic logic is that if operation succeed, set succ to true and do the clean work. If
* operation failed and require to resend it to the same server, leave the succ as false. If
* operation failed and require to resend it to another server, set succ to true and upper layer
* should be able to find out this operation not work and send a operation to another server.
*/
public abstract class ServerRemoteProcedure extends Procedure<MasterProcedureEnv>
implements RemoteProcedureDispatcher.RemoteProcedure<MasterProcedureEnv, ServerName> {