-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28448 CompressionTest hangs when run over a Ozone ofs path #5771
Conversation
Change-Id: I92fdc0d1ceda10b25a1b7469b49e14a25f3a10bd
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
TestRollbackSCP passed in my local tree so i'll just retrigger and hope it passed this time. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
UT looks quite unstable. Repeated several times and some of them are still failing. I'm sure it's not related to this PR and the failures aren't reproducible in my local tree. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
Nit: Maybe add a comment referring HDDS-10564 ?
This bug was found via Apache Ozone HDDS-10564 PR apache/ozone#6418 |
Thanks @stoty ! |
…che#5771) This bug was found via HDDS-10564.
…fs path (apache#5771) This bug was found via HDDS-10564. Change-Id: Ibd5bffefab03817cb6da91efc8036b95bddcfb14
CompressionTest should close the FileSystem object otherwise some resources may not be released, which caused an Ozone output stream user thread to hang.
Deployed on a cluster, ran the same command
hbase org.apache.hadoop.hbase.util.CompressionTest ofs://ozone/vol1/bucket1/test_file.txt snappy
to verify it no longer hangs on an Ozone path.